Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update lint-md-dependencies to @rollup/plugin-commonjs@23.0.2 @rollup/plugin-node-resolve@15.0.1 rollup@3.2.3 #45237

Merged
merged 1 commit into from Oct 31, 2022
Merged

tools: update lint-md-dependencies to @rollup/plugin-commonjs@23.0.2 @rollup/plugin-node-resolve@15.0.1 rollup@3.2.3 #45237

merged 1 commit into from Oct 31, 2022

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of lint-md-dependencies to @rollup/plugin-commonjs@23.0.2 @rollup/plugin-node-resolve@15.0.1 rollup@3.2.3.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 30, 2022
@aduh95 aduh95 added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 30, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

MoLow
MoLow approved these changes Oct 30, 2022
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what needs to be done in cases like this where the commit message is too long

@Trott
Copy link
Member

Trott commented Oct 30, 2022

not sure what needs to be done in cases like this where the commit message is too long

I usually check out the branch, edit the commit message, and force-push it back to the feature branch. I'll do that now.

@nodejs-github-bot @Trott
tools: update lint-md-dependencies
72e4905 
Update @rollup/plugin-commonjs@23.0.2,
@rollup/plugin-node-resolve@15.0.1, and
rollup@3.2.3.
@Trott Trott force-pushed the actions/tools-update-lint-md-dependencies branch from d5e5fa3 to 72e4905 Compare October 30, 2022 16:32
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 30, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 30, 2022
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/47575/

@aduh95
Copy link
Contributor

aduh95 commented Oct 30, 2022 •
edited

not sure what needs to be done in cases like this where the commit message is too long

I usually check out the branch, edit the commit message, and force-push it back to the feature branch. I'll do that now.

Another solution would be to leave it as is and to land it manually, editing the commit message at that time. It's the same result, the only difference being that you save one CI cycle.

Speaking of CI, I don't think we need to have a passing Jenkins CI for that kind of change (it's only changing the name of a class), all the CI failures look unrelated anyway.

@Trott
Copy link
Member

Trott commented Oct 30, 2022

Speaking of CI, I don't think we need to have a passing Jenkins CI for that kind of change (it's only changing the name of a class), all the CI failures look unrelated anyway.

I guess I'm still scarred from that one time that a change in lint-md caused CI failures in...like...was it build-without-intl or something? I forget. Some non-default CI build that we test.

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/47579/

@github-actions github-actions bot mentioned this pull request Oct 31, 2022
Open
19 tasks
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/47587/

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 31, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 31, 2022
@nodejs-github-bot nodejs-github-bot merged commit 548f505 into main Oct 31, 2022
@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-lint-md-dependencies branch October 31, 2022 16:25
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 548f505

@github-actions github-actions bot mentioned this pull request Nov 1, 2022
Open
17 tasks
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@nodejs-github-bot @RafaelGSS
tools: update lint-md-dependencies
d7dbe93 
Update @rollup/plugin-commonjs@23.0.2,
@rollup/plugin-node-resolve@15.0.1, and
rollup@3.2.3.

PR-URL: #45237
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
@github-actions github-actions bot mentioned this pull request Nov 2, 2022
Open
15 tasks
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 9, 2022
@nodejs-github-bot
tools: update lint-md-dependencies
1c7f53d 
Update @rollup/plugin-commonjs@23.0.2,
@rollup/plugin-node-resolve@15.0.1, and
rollup@3.2.3.

PR-URL: nodejs#45237
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@nodejs-github-bot @RafaelGSS
tools: update lint-md-dependencies
ba89cea 
Update @rollup/plugin-commonjs@23.0.2,
@rollup/plugin-node-resolve@15.0.1, and
rollup@3.2.3.

PR-URL: #45237
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@nodejs-github-bot @danielleadams
tools: update lint-md-dependencies
0bdaadb 
Update @rollup/plugin-commonjs@23.0.2,
@rollup/plugin-node-resolve@15.0.1, and
rollup@3.2.3.

PR-URL: #45237
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@nodejs-github-bot @danielleadams
tools: update lint-md-dependencies
abc75de 
Update @rollup/plugin-commonjs@23.0.2,
@rollup/plugin-node-resolve@15.0.1, and
rollup@3.2.3.

PR-URL: #45237
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@nodejs-github-bot @danielleadams
tools: update lint-md-dependencies
a93c4f7 
Update @rollup/plugin-commonjs@23.0.2,
@rollup/plugin-node-resolve@15.0.1, and
rollup@3.2.3.

PR-URL: #45237
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@MoLow MoLow MoLow approved these changes

@aduh95 aduh95 aduh95 approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nodejs-github-bot @Trott @aduh95 @MoLow @RaisinTen @VoltrexKeyva