Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: fix JSDoc issues #45243

Closed
wants to merge 2 commits into from
Closed

lib: fix JSDoc issues #45243

wants to merge 2 commits into from

Commits on Nov 2, 2022

  1. lib: fix JSDoc issues

    Updating ESLint and dependencies will start flagging a few additional
    JSDoc issues. One or two of these are simple fixes. The ESM stuff
    requires throwing explicitly in JSDoc'ed functions rather than calling
    another function to throw. I think this makes the code easier to
    understand--you don't need to know that a particular function that
    starts with `throwsIf` *might* throw but something that starts with
    `throwsAnythingElse` will always throw. Instead, it's right there in the
    code. This also might make it easier to improve stack traces if that's
    something we'd like to do at some point.
    Trott committed Nov 2, 2022
    Copy the full SHA
    057430f View commit details
    Browse the repository at this point in the history
  2. tools: update eslint to 8.26.0

    nodejs-github-bot authored and Trott committed Nov 2, 2022
    Copy the full SHA
    d109e09 View commit details
    Browse the repository at this point in the history