Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: update collaborator email address in README #45251

Merged
merged 1 commit into from Nov 1, 2022
Merged

meta: update collaborator email address in README #45251

merged 1 commit into from Nov 1, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 31, 2022

No description provided.

@Trott Trott requested a review from srl295 October 31, 2022 06:13
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 31, 2022
@mscdex
Copy link
Contributor

mscdex commented Oct 31, 2022

s/udpate/update in commit message

@Trott Trott changed the title meta: udpate collaborator email address in README meta: update collaborator email address in README Oct 31, 2022
@Trott
Copy link
Member Author

Trott commented Oct 31, 2022

s/udpate/update in commit message

Thanks. Fixed.

@srl295
Copy link
Member

srl295 commented Oct 31, 2022

@Trott thanks for the ping!

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 31, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 1, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 1, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/45251
✔  Done loading data for nodejs/node/pull/45251
----------------------------------- PR info ------------------------------------
Title      meta: update collaborator email address in README (#45251)
Author     Rich Trott  (@Trott)
Branch     Trott:srl -> nodejs:main
Labels     doc, fast-track
Commits    1
 - meta: update collaborator email address in README
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/45251
Reviewed-By: Luigi Pinca 
Reviewed-By: Moshe Atlow 
Reviewed-By: Tobias Nießen 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Steven R Loomis 
Reviewed-By: Richard Lau 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45251
Reviewed-By: Luigi Pinca 
Reviewed-By: Moshe Atlow 
Reviewed-By: Tobias Nießen 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Steven R Loomis 
Reviewed-By: Richard Lau 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 31 Oct 2022 06:12:53 GMT
   ✔  Approvals: 6
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/45251#pullrequestreview-1161371464
   ✔  - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/45251#pullrequestreview-1161387643
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/45251#pullrequestreview-1161867814
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45251#pullrequestreview-1162065144
   ✔  - Steven R Loomis (@srl295): https://github.com/nodejs/node/pull/45251#pullrequestreview-1162599661
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/45251#pullrequestreview-1162677314
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least two collaborators' approvals (👍).
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3365827760

@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 1, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 1, 2022
@nodejs-github-bot nodejs-github-bot merged commit 6ccb069 into nodejs:main Nov 1, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 6ccb069

@Trott Trott deleted the srl branch November 1, 2022 05:26
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@Trott @RafaelGSS
meta: update collaborator email address in README
de9dc2b 
PR-URL: #45251
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 9, 2022
@Trott
meta: update collaborator email address in README
e94c9eb 
PR-URL: nodejs#45251
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@Trott @RafaelGSS
meta: update collaborator email address in README
a866e8c 
PR-URL: #45251
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@Trott @danielleadams
meta: update collaborator email address in README
21dcdf5 
PR-URL: #45251
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@Trott @danielleadams
meta: update collaborator email address in README
844ac6d 
PR-URL: #45251
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@Trott @danielleadams
meta: update collaborator email address in README
255e89d 
PR-URL: #45251
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srl295 srl295 srl295 approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@tniessen tniessen tniessen approved these changes

@richardlau richardlau richardlau approved these changes

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@Trott @mscdex @srl295 @nodejs-github-bot @lpinca @anonrig @tniessen @richardlau @MoLow