v19.1.0 proposal

.github/label-pr-config.yml

@@ -31,8 +31,8 @@ subSystemLabels:
   /^src\/node_report/: c++, report
   /^src\/node_wasi/: c++, wasi
   /^src\/node_worker/: c++, worker
-  /^src\/quic\/*/: c++, quic, dont-land-on-v14.x, dont-land-on-v12.x
-  /^src\/node_bob*/: c++, quic, dont-land-on-v14.x, dont-land-on-v12.x
+  /^src\/quic\/*/: c++, quic, dont-land-on-v14.x
+  /^src\/node_bob*/: c++, quic, dont-land-on-v14.x
 
   # don't label python files as c++
   /^src\/.+\.py$/: python, needs-ci
@@ -54,7 +54,7 @@ subSystemLabels:
   /^vcbuild\.bat$/: build, windows, needs-ci
   /^(android-)?configure|node\.gyp|common\.gypi$/: build, needs-ci
   # more specific tools
-  /^tools\/gyp/: tools, build, gyp, needs-ci, dont-land-on-v14.x, dont-land-on-v12.x
+  /^tools\/gyp/: tools, build, gyp, needs-ci, dont-land-on-v14.x
   /^tools\/doc\//: tools, doc
   /^tools\/icu\//: tools, i18n-api, icu, needs-ci
   /^tools\/(?:osx-pkg\.pmdoc|pkgsrc)\//: tools, macos, install
@@ -80,11 +80,11 @@ subSystemLabels:
   /^deps\/v8\/tools\/gen-postmortem-metadata\.py/: v8 engine, python, post-mortem
   /^deps\/v8\//: v8 engine
   /^deps\/uvwasi\//: wasi
-  /^deps\/npm\//: npm, fast-track, dont-land-on-v14.x, dont-land-on-v12.x
+  /^deps\/npm\//: npm, fast-track, dont-land-on-v14.x
   /^deps\/nghttp2\/nghttp2\.gyp/: build, http2
   /^deps\/nghttp2\//: http2
-  /^deps\/ngtcp2\//: quic, dont-land-on-v14.x, dont-land-on-v12.x
-  /^deps\/nghttp3\//: quic, dont-land-on-v14.x, dont-land-on-v12.x
+  /^deps\/ngtcp2\//: quic, dont-land-on-v14.x
+  /^deps\/nghttp3\//: quic, dont-land-on-v14.x
   /^deps\/([^/]+)/: dependencies, $1
 
   ## JS subsystems
@@ -138,7 +138,7 @@ exlusiveLabels:
   # considered a subsystem of sorts
   /^doc\/api\/n-api.md$/: doc, node-api
   # quic
-  /^doc\/api\/quic.md$/: doc, quic, dont-land-on-v14.x, dont-land-on-v12.x
+  /^doc\/api\/quic.md$/: doc, quic, dont-land-on-v14.x
   # Add worker label to PRs that affect doc/api/worker_threads.md
   /^doc\/api\/worker_threads.md$/: doc, worker
   # test runner documentation

.github/workflows/authors.yml

@@ -19,7 +19,7 @@ jobs:
           fetch-depth: '0'  # This is required to actually get all the authors
           persist-credentials: false
       - run: tools/update-authors.mjs  # Run the AUTHORS tool
-      - uses: gr2m/create-or-update-pull-request-action@6720400cad8e74d7adc64640e4e6ea6748b83d8f
+      - uses: gr2m/create-or-update-pull-request-action@dc1726cbf4dd3ce766af4ec29cfb660e0125e8ee
         # Creates a PR or update the Action's existing PR, or
         # no-op if the base branch is already up-to-date.
         env:

.github/workflows/auto-start-ci.yml

@@ -10,8 +10,9 @@ on:
 
 concurrency: ${{ github.workflow }}
 
+# todo (node-fetch not working on 18, waiting for node-core-utils to fix)
 env:
-  NODE_VERSION: lts/*
+  NODE_VERSION: 16
 
 permissions:
   contents: read
@@ -28,12 +29,13 @@ jobs:
       - name: Get Pull Requests
         id: get_prs_for_ci
         run: >
-          gh pr list \
+          numbers=$(gh pr list \
                   --repo ${{ github.repository }} \
                   --label 'request-ci' \
                   --json 'number' \
-                  -t '::set-output name=numbers::{{ range . }}{{ .number }} {{ end }}' \
-                  --limit 100
+                  -t '{{ range . }}{{ .number }} {{ end }}' \
+                  --limit 100)
+          echo "numbers=$numbers" >> $GITHUB_OUTPUT
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
   start-ci:
@@ -59,7 +61,7 @@ jobs:
       - name: Setup node-core-utils
         run: |
           ncu-config set username ${{ secrets.JENKINS_USER }}
-          ncu-config set token none
+          ncu-config set token "${{ secrets.GH_USER_TOKEN }}"
           ncu-config set jenkins_token ${{ secrets.JENKINS_TOKEN }}
           ncu-config set owner "${{ github.repository_owner }}"
           ncu-config set repo "$(echo ${{ github.repository }} | cut -d/ -f2)"

.github/workflows/build-tarball.yml

@@ -28,7 +28,7 @@ concurrency:
   cancel-in-progress: true
 
 env:
-  PYTHON_VERSION: '3.10'
+  PYTHON_VERSION: '3.11'
   FLAKY_TESTS: keep_retrying
 
 permissions:
@@ -43,7 +43,7 @@ jobs:
         with:
           persist-credentials: false
       - name: Set up Python ${{ env.PYTHON_VERSION }}
-        uses: actions/setup-python@v3
+        uses: actions/setup-python@v4
         with:
           python-version: ${{ env.PYTHON_VERSION }}
       - name: Environment Information
@@ -69,7 +69,7 @@ jobs:
         with:
           persist-credentials: false
       - name: Set up Python ${{ env.PYTHON_VERSION }}
-        uses: actions/setup-python@v3
+        uses: actions/setup-python@v4
         with:
           python-version: ${{ env.PYTHON_VERSION }}
       - name: Environment Information

.github/workflows/build-windows.yml

@@ -23,7 +23,7 @@ concurrency:
   cancel-in-progress: true
 
 env:
-  PYTHON_VERSION: '3.10'
+  PYTHON_VERSION: '3.11'
   FLAKY_TESTS: keep_retrying
 
 permissions:
@@ -42,7 +42,7 @@ jobs:
         with:
           persist-credentials: false
       - name: Set up Python ${{ env.PYTHON_VERSION }}
-        uses: actions/setup-python@v3
+        uses: actions/setup-python@v4
         with:
           python-version: ${{ env.PYTHON_VERSION }}
       - name: Install deps

.github/workflows/commit-lint.yml

@@ -15,8 +15,8 @@ jobs:
       - name: Compute number of commits in the PR
         id: nb-of-commits
         run: |
-          echo "::set-output name=plusOne::$((${{ github.event.pull_request.commits }} + 1))"
-          echo "::set-output name=minusOne::$((${{ github.event.pull_request.commits }} - 1))"
+          echo "plusOne=$((${{ github.event.pull_request.commits }} + 1))" >> $GITHUB_OUTPUT
+          echo "minusOne=$((${{ github.event.pull_request.commits }} - 1))" >> $GITHUB_OUTPUT
       - uses: actions/checkout@v3
         with:
           fetch-depth: ${{ steps.nb-of-commits.outputs.plusOne }}

.github/workflows/commit-queue.yml

@@ -33,13 +33,14 @@ jobs:
       - name: Get Pull Requests
         id: get_mergeable_prs
         run: >
-          gh pr list \
+          numbers=$(gh pr list \
                   --repo ${{ github.repository }} \
                   --base ${{ github.ref_name }} \
                   --label 'commit-queue' \
                   --json 'number' \
-                  -t '::set-output name=numbers::{{ range . }}{{ .number }} {{ end }}' \
-                  --limit 100
+                  -t '{{ range . }}{{ .number }} {{ end }}' \
+                  --limit 100)
+          echo "numbers=$numbers" >> $GITHUB_OUTPUT
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
   commitQueue:

.github/workflows/coverage-linux.yml

@@ -26,7 +26,7 @@ concurrency:
   cancel-in-progress: true
 
 env:
-  PYTHON_VERSION: '3.10'
+  PYTHON_VERSION: '3.11'
   FLAKY_TESTS: keep_retrying
 
 permissions:
@@ -41,7 +41,7 @@ jobs:
         with:
           persist-credentials: false
       - name: Set up Python ${{ env.PYTHON_VERSION }}
-        uses: actions/setup-python@v3
+        uses: actions/setup-python@v4
         with:
           python-version: ${{ env.PYTHON_VERSION }}
       - name: Environment Information

.github/workflows/coverage-windows.yml

@@ -28,7 +28,7 @@ concurrency:
   cancel-in-progress: true
 
 env:
-  PYTHON_VERSION: '3.10'
+  PYTHON_VERSION: '3.11'
   FLAKY_TESTS: keep_retrying
 
 permissions:
@@ -43,7 +43,7 @@ jobs:
         with:
           persist-credentials: false
       - name: Set up Python ${{ env.PYTHON_VERSION }}
-        uses: actions/setup-python@v3
+        uses: actions/setup-python@v4
         with:
           python-version: ${{ env.PYTHON_VERSION }}
       - name: Install deps

.github/workflows/find-inactive-collaborators.yml

@@ -33,7 +33,7 @@ jobs:
         run: tools/find-inactive-collaborators.mjs
 
       - name: Open pull request
-        uses: gr2m/create-or-update-pull-request-action@6720400cad8e74d7adc64640e4e6ea6748b83d8f
+        uses: gr2m/create-or-update-pull-request-action@dc1726cbf4dd3ce766af4ec29cfb660e0125e8ee
         # Creates a PR or update the Action's existing PR, or
         # no-op if the base branch is already up-to-date.
         env:

.github/workflows/find-inactive-tsc.yml

@@ -42,7 +42,7 @@ jobs:
         run: tools/find-inactive-tsc.mjs >> $GITHUB_ENV
 
       - name: Open pull request
-        uses: gr2m/create-or-update-pull-request-action@6720400cad8e74d7adc64640e4e6ea6748b83d8f
+        uses: gr2m/create-or-update-pull-request-action@dc1726cbf4dd3ce766af4ec29cfb660e0125e8ee
         # Creates a PR or update the Action's existing PR, or
         # no-op if the base branch is already up-to-date.
         env:

.github/workflows/label-flaky-test-issue.yml

@@ -41,7 +41,7 @@ jobs:
             labels="${labels}${platform2label[$platform]},"; \
           done;
 
-          echo "::set-output name=LABELS::${labels::-1}"
+          echo "LABELS=${labels::-1}" >> $GITHUB_OUTPUT
 
       - name: Add labels
         env:

.github/workflows/license-builder.yml

@@ -21,7 +21,7 @@ jobs:
         with:
           persist-credentials: false
       - run: ./tools/license-builder.sh  # Run the license builder tool
-      - uses: gr2m/create-or-update-pull-request-action@6720400cad8e74d7adc64640e4e6ea6748b83d8f
+      - uses: gr2m/create-or-update-pull-request-action@dc1726cbf4dd3ce766af4ec29cfb660e0125e8ee
         # Creates a PR or update the Action's existing PR, or
         # no-op if the base branch is already up-to-date.
         env:

.github/workflows/linters.yml

@@ -14,7 +14,7 @@ concurrency:
   cancel-in-progress: true
 
 env:
-  PYTHON_VERSION: '3.10'
+  PYTHON_VERSION: '3.11'
   NODE_VERSION: lts/*
 
 permissions:
@@ -44,7 +44,7 @@ jobs:
         with:
           persist-credentials: false
       - name: Set up Python ${{ env.PYTHON_VERSION }}
-        uses: actions/setup-python@v3
+        uses: actions/setup-python@v4
         with:
           python-version: ${{ env.PYTHON_VERSION }}
       - name: Environment Information
@@ -64,7 +64,7 @@ jobs:
         with:
           node-version: ${{ env.NODE_VERSION }}
       - name: Set up Python ${{ env.PYTHON_VERSION }}
-        uses: actions/setup-python@v3
+        uses: actions/setup-python@v4
         with:
           python-version: ${{ env.PYTHON_VERSION }}
       - name: Environment Information
@@ -122,7 +122,7 @@ jobs:
         with:
           persist-credentials: false
       - name: Set up Python ${{ env.PYTHON_VERSION }}
-        uses: actions/setup-python@v3
+        uses: actions/setup-python@v4
         with:
           python-version: ${{ env.PYTHON_VERSION }}
       - name: Environment Information
@@ -139,7 +139,7 @@ jobs:
         with:
           persist-credentials: false
       - name: Use Python ${{ env.PYTHON_VERSION }}
-        uses: actions/setup-python@v3
+        uses: actions/setup-python@v4
         with:
           python-version: ${{ env.PYTHON_VERSION }}
       - name: Environment Information

.github/workflows/test-asan.yml

@@ -30,7 +30,7 @@ concurrency:
 
 env:
   ASAN_OPTIONS: intercept_tls_get_addr=0
-  PYTHON_VERSION: '3.10'
+  PYTHON_VERSION: '3.11'
   FLAKY_TESTS: keep_retrying
 
 permissions:
@@ -50,7 +50,7 @@ jobs:
         with:
           persist-credentials: false
       - name: Set up Python ${{ env.PYTHON_VERSION }}
-        uses: actions/setup-python@v3
+        uses: actions/setup-python@v4
         with:
           python-version: ${{ env.PYTHON_VERSION }}
       - name: Environment Information

.github/workflows/test-internet.yml

@@ -21,7 +21,7 @@ concurrency:
   cancel-in-progress: true
 
 env:
-  PYTHON_VERSION: '3.10'
+  PYTHON_VERSION: '3.11'
   FLAKY_TESTS: keep_retrying
 
 permissions:
@@ -36,7 +36,7 @@ jobs:
         with:
           persist-credentials: false
       - name: Set up Python ${{ env.PYTHON_VERSION }}
-        uses: actions/setup-python@v3
+        uses: actions/setup-python@v4
         with:
           python-version: ${{ env.PYTHON_VERSION }}
       - name: Environment Information

.github/workflows/test-linux.yml

@@ -23,7 +23,7 @@ concurrency:
   cancel-in-progress: true
 
 env:
-  PYTHON_VERSION: '3.10'
+  PYTHON_VERSION: '3.11'
   FLAKY_TESTS: keep_retrying
 
 permissions:
@@ -38,7 +38,7 @@ jobs:
         with:
           persist-credentials: false
       - name: Set up Python ${{ env.PYTHON_VERSION }}
-        uses: actions/setup-python@v3
+        uses: actions/setup-python@v4
         with:
           python-version: ${{ env.PYTHON_VERSION }}
       - name: Environment Information

.github/workflows/test-macos.yml

@@ -29,7 +29,7 @@ concurrency:
   cancel-in-progress: true
 
 env:
-  PYTHON_VERSION: '3.10'
+  PYTHON_VERSION: '3.11'
   FLAKY_TESTS: keep_retrying
 
 permissions:
@@ -44,20 +44,20 @@ jobs:
         with:
           persist-credentials: false
       - name: Set up Python ${{ env.PYTHON_VERSION }}
-        uses: actions/setup-python@v3
+        uses: actions/setup-python@v4
         with:
           python-version: ${{ env.PYTHON_VERSION }}
       - name: Environment Information
         run: npx envinfo
       # The `npm ci` for this step fails a lot as part of the Test step. Run it
       # now so that we don't have to wait 2 hours for the Build step to pass
       # first before that failure happens. (And if there's something about
-      # `make run-ci -j2` that is causing the failure and the failure doesn't
+      # `make run-ci -j3` that is causing the failure and the failure doesn't
       # happen anymore running this step here first, that's also useful
       # information.)
       - name: tools/doc/node_modules workaround
         run: make tools/doc/node_modules
       - name: Build
-        run: make build-ci -j2 V=1 CONFIG_FLAGS="--error-on-warn"
+        run: make build-ci -j3 V=1 CONFIG_FLAGS="--error-on-warn"
       - name: Test
-        run: make run-ci -j2 V=1 TEST_CI_ARGS="-p actions --measure-flakiness 9"
+        run: make run-ci -j3 V=1 TEST_CI_ARGS="-p actions --measure-flakiness 9"

.github/workflows/timezone-update.yml

@@ -31,10 +31,13 @@ jobs:
           persist-credentials: false
           repository: unicode-org/icu-data
 
+      - name: Record new version
+        run: echo "new_version=$(ls icu-data/tzdata/icunew | tail -1)" >> $GITHUB_ENV
+
       - run: ./tools/update-timezone.mjs
 
       - name: Open Pull Request
-        uses: gr2m/create-or-update-pull-request-action@6720400cad8e74d7adc64640e4e6ea6748b83d8f  # Create a PR or update the Action's existing PR
+        uses: gr2m/create-or-update-pull-request-action@dc1726cbf4dd3ce766af4ec29cfb660e0125e8ee  # Create a PR or update the Action's existing PR
         env:
           GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
         with:
@@ -49,7 +52,7 @@ jobs:
             console.log(process.versions.tz)
             ```
           branch: actions/timezone-update
-          commit-message: 'deps: update timezone'
+          commit-message: 'deps: update timezone to ${{ env.new_version }}'
           labels: dependencies
-          title: 'deps: update timezone'
+          title: 'deps: update timezone to ${{ env.new_version }}'
           reviewers: \@nodejs/i18n-api