Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add a test to ensure the correctness of timezone upgrades #45299

Merged
merged 7 commits into from Nov 10, 2022
Merged

test: add a test to ensure the correctness of timezone upgrades #45299

merged 7 commits into from Nov 10, 2022

Commits on Nov 3, 2022

  1. test: add a test to ensure the correctness of timezone upgrades 

    Currently, there's no way to know if a timezone upgrade PR is correct
without building and testing the change locally. This change provides a
solution for that.

Tested in #4.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
    @RaisinTen
    RaisinTen committed Nov 3, 2022
    Copy the full SHA
    3f2e5e3 View commit details
    Browse the repository at this point in the history

  2. fixup! test: address review comments and skip if no intl 

    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    @RaisinTen
    RaisinTen committed Nov 3, 2022
    Copy the full SHA
    f004140 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2022

  1. fixup! test: intl -> Intl in skip message 

    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    @RaisinTen
    RaisinTen committed Nov 4, 2022
    Copy the full SHA
    8780765 View commit details
    Browse the repository at this point in the history

  2. fixup! test: add extra guards 

    Refs: nodejs#45299 (comment)
Signed-off-by: Darshan Sen <raisinten@gmail.com>
    @RaisinTen
    RaisinTen committed Nov 4, 2022
    Copy the full SHA
    693f9bc View commit details
    Browse the repository at this point in the history

  3. fixup! test: add link to canned icu directory path 

    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    @RaisinTen
    RaisinTen committed Nov 4, 2022
    Copy the full SHA
    69ec584 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2022

  1. fixup! test: explain difference between small-icu and deps/icu-small 

    Asked for in
nodejs#45299 (comment).

Signed-off-by: Darshan Sen <raisinten@gmail.com>
    @RaisinTen
    RaisinTen committed Nov 6, 2022
    Copy the full SHA
    c3ee434 View commit details
    Browse the repository at this point in the history

  2. fixup! test: fix typo configured -> configure 

    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    @RaisinTen
    RaisinTen committed Nov 6, 2022
    Copy the full SHA
    dfa9a34 View commit details
    Browse the repository at this point in the history