src: revert is_release to 0 #45315
Closed
src: revert is_release to 0 #45315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fast-track has been requested by @RafaelGSS. Please 👍 to approve. |
panva
approved these changes
Nov 4, 2022
richardlau
approved these changes
Nov 4, 2022
anonrig
approved these changes
Nov 4, 2022
danielleadams
approved these changes
Nov 4, 2022
github-actions
bot
removed
the
request-ci
|
@nodejs/tsc Can we merge this without waiting for CI? It affects all new pull requests. |
+1, we should as it'll cause failures elsewhere without it. |
|
+1 from me as well to merge |
|
But of course not with the squash and merge. I assume it will need to be landed manually. |
anonrig
pushed a commit
that referenced
this pull request
Nov 4, 2022
PR-URL: #45315 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
|
Landed in 7124476 |
This was referenced Nov 4, 2022
This was referenced Nov 6, 2022
lucshi
pushed a commit
to lucshi/node
that referenced
this pull request
Nov 9, 2022
PR-URL: nodejs#45315 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
RafaelGSS
added a commit
that referenced
this pull request
Nov 10, 2022
PR-URL: #45315 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
danielleadams
added
the
dont-land-on-v18.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was wrongly committed on the v19.0.1 release.