Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async_hooks: add hook to stop propagation #45386

Merged
merged 8 commits into from Nov 15, 2022
Merged

async_hooks: add hook to stop propagation #45386

merged 8 commits into from Nov 15, 2022

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Nov 9, 2022

Add hook to AsyncLocalStorage to allow user to stop propagation. This is needed to avoid leaking a store if e.g. the store indicates that its operations are finished or it reached its time to live.

fyi @nodejs/diagnostics

@Flarna
async_hooks: add hook to stop propagation
133d061 
Add hook to AsyncLocalStorage to allow user to stop propagation.
This is needed to avoid leaking a store if e.g. the store indicates
that its operations are finished or it reached its time to live.
@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. needs-ci PRs that need a full CI run. labels Nov 9, 2022
Flarna
Flarna commented Nov 9, 2022
View reviewed changes
lib/async_hooks.js Outdated Show resolved Hide resolved
@Flarna Flarna added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 9, 2022
@Flarna Flarna added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Nov 9, 2022
Qard
Qard requested changes Nov 9, 2022
View reviewed changes
lib/async_hooks.js Outdated Show resolved Hide resolved
doc/api/async_context.md Outdated Show resolved Hide resolved
tony-go
tony-go approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@tony-go tony-go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

legendecas
legendecas reviewed Nov 14, 2022
View reviewed changes
lib/async_hooks.js Outdated Show resolved Hide resolved
@Flarna @legendecas
use kEmptyObject instead {}
358297c 
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
@Flarna Flarna added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 14, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 14, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47932/

@Flarna Flarna added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 15, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 15, 2022
@nodejs-github-bot nodejs-github-bot merged commit 67d1831 into nodejs:main Nov 15, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 67d1831

@Flarna Flarna deleted the als-propagate branch November 15, 2022 12:29
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@Flarna @ruyadorno
async_hooks: add hook to stop propagation
7cff1e1 
Add hook to AsyncLocalStorage to allow user to stop propagation.
This is needed to avoid leaking a store if e.g. the store indicates
that its operations are finished or it reached its time to live.

PR-URL: #45386
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@Flarna @danielleadams
async_hooks: add hook to stop propagation
922df8b 
Add hook to AsyncLocalStorage to allow user to stop propagation.
This is needed to avoid leaking a store if e.g. the store indicates
that its operations are finished or it reached its time to live.

PR-URL: #45386
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@Flarna @danielleadams
async_hooks: add hook to stop propagation
2d3c6da 
Add hook to AsyncLocalStorage to allow user to stop propagation.
This is needed to avoid leaking a store if e.g. the store indicates
that its operations are finished or it reached its time to live.

PR-URL: #45386
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@Flarna @danielleadams
async_hooks: add hook to stop propagation
40123a6 
Add hook to AsyncLocalStorage to allow user to stop propagation.
This is needed to avoid leaking a store if e.g. the store indicates
that its operations are finished or it reached its time to live.

PR-URL: #45386
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@Flarna @danielleadams
async_hooks: add hook to stop propagation
2d1740c 
Add hook to AsyncLocalStorage to allow user to stop propagation.
This is needed to avoid leaking a store if e.g. the store indicates
that its operations are finished or it reached its time to live.

PR-URL: #45386
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@legendecas legendecas mentioned this pull request Jan 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qard Qard Qard approved these changes

@JungMinu JungMinu JungMinu approved these changes

@legendecas legendecas legendecas approved these changes

@tony-go tony-go tony-go approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Flarna @nodejs-github-bot @Qard @JungMinu @legendecas @tony-go