Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update zlib to upstream 8bbd6c31 #45387

Closed
wants to merge 2 commits into from
Closed

deps: update zlib to upstream 8bbd6c31 #45387

wants to merge 2 commits into from

Commits on Nov 15, 2022

  1. deps: update zlib to upstream 8bbd6c31 

    Updated as described in doc/contributing/maintaining-zlib.md.
    @lpinca
    lpinca committed Nov 15, 2022
    Copy the full SHA
    5ec56bf View commit details
    Browse the repository at this point in the history

  2. deps: fix zlib compilation for CPUs without SIMD features 

    Fix the compile flags so that zlib can run on CPUs that do
not have SSSE3/SSE4.2/etc. Do not compile zlib with flags that
indicate that those features are available, and instead enable
them selectively for functions that use them.

There are probably better way to do this, e.g. through gyp file
modifications as suggested in the issue. However, this patch
should do just fine until that happens.

Fixes: nodejs#32553

PR-URL: nodejs#32627
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @addaleax @lpinca
    addaleax authored and lpinca committed Nov 15, 2022
    Copy the full SHA
    76007d2 View commit details
    Browse the repository at this point in the history