Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: simplify regex in ESLint config #45399

Merged
merged 1 commit into from Nov 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions .eslintrc.js
Expand Up @@ -126,8 +126,7 @@ module.exports = {
line: {
// Ignore all lines that have less characters than 20 and all lines that
// start with something that looks like a variable name or code.
// eslint-disable-next-line max-len
ignorePattern: '.{0,20}$|[a-z]+ ?[0-9A-Z_.(/=:[#-]|std|http|ssh|ftp|(let|var|const) [a-z_A-Z0-9]+ =|[b-z] |[a-z]*[0-9].* ',
ignorePattern: '.{0,20}$|[a-z]+ ?[0-9A-Z_.(/=:[#-]|std|http|ssh|ftp',
ignoreInlineComments: true,
ignoreConsecutiveComments: true,
},
Expand Down
2 changes: 0 additions & 2 deletions test/parallel/test-fs-readv-promises.js
Expand Up @@ -29,7 +29,6 @@ const allocateEmptyBuffers = (combinedLength) => {
const filename = getFileName();
await fs.writeFile(filename, exptectedBuff);
const handle = await fs.open(filename, 'r');
// const buffer = Buffer.from(expected);
const bufferArr = allocateEmptyBuffers(exptectedBuff.length);
const expectedLength = exptectedBuff.length;

Expand All @@ -49,7 +48,6 @@ const allocateEmptyBuffers = (combinedLength) => {
const filename = getFileName();
await fs.writeFile(filename, exptectedBuff);
const handle = await fs.open(filename, 'r');
// const buffer = Buffer.from(expected);
const bufferArr = allocateEmptyBuffers(exptectedBuff.length);
const expectedLength = exptectedBuff.length;

Expand Down