No call to SetIdle() when terminating #45422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
ywave620
changed the title
Calling SetIdle() when terminating is not harmless. When node terminates due to an unhandled exception, v8 preseves the vm state, which is JS and notifies node through PerIsolateMessageListener(). If node calls SetIdle() later, v8 complains because it requires the vm state to either be EXTERNEL or IDLE when embedder calling SetIdle().
ywave620
force-pushed
the
no-SetIdle-when-terminating
branch
from
24958ca
to
c0e3840
Compare
|
Welcome to join discussion about v8's behavior in https://bugs.chromium.org/p/v8/issues/detail?id=13464 |
bnoordhuis
approved these changes
Nov 12, 2022
Fix typo Co-authored-by: Ben Noordhuis <info@bnoordhuis.nl>
bnoordhuis
approved these changes
Nov 15, 2022
bnoordhuis
added
request-ci
github-actions
bot
removed
the
request-ci
legendecas
reviewed
Nov 15, 2022
use fixture function to check no abort
legendecas
approved these changes
Nov 16, 2022
github-actions
bot
removed
the
request-ci
add assertion
fix judgment bug
|
Sry, the previous commits forgets to wrap an asserttion around |
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Nov 16, 2022
This was referenced Nov 17, 2022
joyeecheung
approved these changes
Nov 18, 2022
santigimeno
approved these changes
Nov 18, 2022
10 tasks
theanarkh
approved these changes
Nov 19, 2022
This was referenced Nov 20, 2022
This was referenced Nov 22, 2022
|
I have moved this change to #45596, which includes a fix to another bug about terminating. PTAL. |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #45421, where you can find a helpful stack trace
One can argues that v8 is responsable for transfering vm state to EXTERNAL before invoking
PerIsolateMessageListener(), if v8 agrees and changes for it, this issue is gone without any change of Node.js. However,SetIdle()is basically for cpu profiling only, it's not necessary when terminating. Removing it is not harmful while otherwise will lead to crash before v8 makes that change.