build: make scripts in gyp run with right python #45435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
github-actions
bot
removed
the
request-ci
gengjiawen
added
the
fast-track
|
Fast-track has been requested by @gengjiawen. Please 👍 to approve. |
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Nov 12, 2022
This was referenced Nov 13, 2022
ryzokuken
approved these changes
Nov 14, 2022
gengjiawen
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
This comment was marked as outdated.
This comment was marked as outdated.
gengjiawen
removed
commit-queue-failed
gengjiawen
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/45435 ✔ Done loading data for nodejs/node/pull/45435 ----------------------------------- PR info ------------------------------------ Title build: make scripts in gyp run with right python (#45435) Author Jiawen Geng (@gengjiawen) Branch gengjiawen:fix/v8 -> nodejs:main Labels v8 engine, tools, needs-ci Commits 1 - build: make scripts in gyp run with right python Committers 1 - Jiawen Geng PR-URL: https://github.com/nodejs/node/pull/45435 Reviewed-By: Luigi Pinca Reviewed-By: Ujjwal Sharma ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45435 Reviewed-By: Luigi Pinca Reviewed-By: Ujjwal Sharma -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 12 Nov 2022 04:39:11 GMT ✔ Approvals: 2 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/45435#pullrequestreview-1178150507 ✔ - Ujjwal Sharma (@ryzokuken): https://github.com/nodejs/node/pull/45435#pullrequestreview-1178494322 ✖ Last GitHub CI failed ℹ Last Full PR CI on 2022-11-14T08:03:56Z: https://ci.nodejs.org/job/node-test-pull-request/47878/ - Querying data for job/node-test-pull-request/47878/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3459513650 |
This was referenced Nov 15, 2022
ruyadorno
pushed a commit
that referenced
this pull request
Nov 21, 2022
PR-URL: #45435 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45435 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45435 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #45435 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
danielleadams
pushed a commit
that referenced
this pull request
Jan 4, 2023
PR-URL: #45435 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #39730. I run into issues on m1 macOS 13.0