Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: fix fs.rm support for loop symlinks #45439

Merged
merged 4 commits into from Nov 18, 2022
Merged

fs: fix fs.rm support for loop symlinks #45439

merged 4 commits into from Nov 18, 2022

Commits on Nov 13, 2022

  1. fs: fix fs.rm support for loop symlinks 

    Fixes: nodejs#45404
    @nathanael-ruf
    nathanael-ruf committed Nov 13, 2022
    Copy the full SHA
    8455a62 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2022

  1. fs: ass missing assertions to test-fs-rm tests

    @nathanael-ruf
    nathanael-ruf committed Nov 14, 2022
    Copy the full SHA
    11b190d View commit details
    Browse the repository at this point in the history

  2. fs: remove exists check for remaining loop symlinks

    @nathanael-ruf
    nathanael-ruf committed Nov 14, 2022
    Copy the full SHA
    bc3ec4a View commit details
    Browse the repository at this point in the history

  3. fs: move assertions of sync loop test into try block 

    Co-authored-by: Livia Medeiros <livia@cirno.name>
    @nathanael-ruf @LiviaMedeiros
    nathanael-ruf and LiviaMedeiros committed Nov 14, 2022
    Copy the full SHA
    6992b22 View commit details
    Browse the repository at this point in the history