Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: cherry-pick 9df5ef70ff18 #45474

Merged
merged 2 commits into from Nov 18, 2022

Commits on Nov 15, 2022

  1. deps: V8: cherry-pick 9df5ef70ff18

    Original commit message:
    
        Add an `v8::ArrayBuffer::WasDetached` method to the C++ API
    
        V8's C++ API does not give a way to tell whether an ArrayBuffer has
        been detached from the `v8::ArrayBuffer` class. In fact, as far as can
        be told from the C++ API without running JS code, detached
        ArrayBuffers behave the same as zero-sized ArrayBuffers and there is
        no way to observe the difference. However, this difference can be
        observed in JS because constructing a TypedArray from a detached
        ArrayBuffer will throw.
    
        This change adds a `WasDetached` method to the `v8::ArrayBuffer` class
        to give embedders access to this information without having to run JS
        code.
    
        Bug: v8:13159
        Change-Id: I2bb1e380cee1cecd31f6d48ec3d9f28c03a8a673
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3810345
        Commit-Queue: Toon Verwaest <verwaest@chromium.org>
        Reviewed-by: Toon Verwaest <verwaest@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#83963}
    
    Refs: v8/v8@9df5ef7
    anonrig committed Nov 15, 2022
    Copy the full SHA
    a1d63fa View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. deps: V8: remove detach check

    anonrig committed Nov 16, 2022
    Copy the full SHA
    4562373 View commit details
    Browse the repository at this point in the history