fs: fix nonNativeWatcher leak of StatWatchers
#45501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
fs
|
CC @nodejs/fs |
anonrig
requested changes
Nov 18, 2022
anonrig
reviewed
Nov 18, 2022
anonrig
approved these changes
Nov 25, 2022
anonrig
added
author ready
github-actions
bot
removed
the
request-ci
21 tasks
github-actions
bot
removed
the
request-ci
21 tasks
MoLow
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/45501 ✔ Done loading data for nodejs/node/pull/45501 ----------------------------------- PR info ------------------------------------ Title fs: fix `nonNativeWatcher` leak of `StatWatchers` (#45501) Author Moshe Atlow (@MoLow) Branch MoLow:fix-recursive-watch-leak -> nodejs:main Labels fs, author ready, needs-ci, commit-queue-squash Commits 6 - fs: fix `nonNativeWatcher` leak of `StatWatchers` - Lint - fix - CR - CR - fix Committers 1 - Moshe Atlow PR-URL: https://github.com/nodejs/node/pull/45501 Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45501 Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - fix ℹ This PR was created on Thu, 17 Nov 2022 22:27:07 GMT ✔ Approvals: 1 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45501#pullrequestreview-1194715945 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-11-26T22:27:48Z: https://ci.nodejs.org/job/node-test-pull-request/48201/ - Querying data for job/node-test-pull-request/48201/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3557422926 |
PR-URL: nodejs#45501 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
MoLow
force-pushed
the
fix-recursive-watch-leak
branch
from
665c6f9
to
b9fbd1c
Compare
|
Landed in b9fbd1c |
20 tasks
This was referenced Nov 29, 2022
ErickWendel
pushed a commit
to ErickWendel/node
that referenced
this pull request
Nov 30, 2022
PR-URL: nodejs#45501 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This was referenced Dec 1, 2022
targos
pushed a commit
that referenced
this pull request
Dec 12, 2022
PR-URL: #45501 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45501 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
|
Hey @MoLow, the test couldn't be pulled into v18.x-staging. Do you mind creating a backport PR? Thanks! |
danielleadams
added
the
backport-requested-v18.x
MoLow
added a commit
to MoLow/node
that referenced
this pull request
Dec 31, 2022
PR-URL: nodejs#45501 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
MoLow
added
backport-open-v18.x
MoLow
added a commit
to MoLow/node
that referenced
this pull request
Jan 5, 2023
PR-URL: nodejs#45501 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a simple reproduction was added as a test