Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "url: improve port validation" #45517

Merged
merged 1 commit into from Nov 19, 2022
Merged

Commits on Nov 19, 2022

  1. Revert "url: improve port validation"

    This reverts commit 5f7730e.
    
    This change broke too many edge cases in the ecosystem. Reverting it
    re-introduces some host-spoofing possibilities, so we won't want to
    revert forever, but the issue is long-lived enough and not sufficiently
    critical that we can't wait for a major release to introduce it as a
    breaking change. After this lands, I plan to re-introduce this as a
    change that throws a warning rather than an error, after which we can
    land a semver-major that re-introduces the error and try to get the word
    out to maintainers of likely-affected packages.
    
    Closes: nodejs#45514
    Refs: nodejs#45012
    Trott committed Nov 19, 2022
    Copy the full SHA
    d6439fd View commit details
    Browse the repository at this point in the history