Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: revise pull request guide text about code #45519

Merged
merged 2 commits into from Nov 19, 2022
Merged

test: revise pull request guide text about code #45519

merged 2 commits into from Nov 19, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 19, 2022

Fixes: #45502

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 19, 2022
@Trott Trott mentioned this pull request Nov 19, 2022
Closed
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 19, 2022
@lpinca lpinca added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 19, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @lpinca. Please 👍 to approve.

@anonrig anonrig added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Nov 19, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 19, 2022
@nodejs-github-bot nodejs-github-bot merged commit 5af2021 into nodejs:main Nov 19, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 5af2021

@Trott Trott deleted the foo branch November 19, 2022 20:07
ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@Trott @ruyadorno
test: revise pull request guide text about code
c9ba0b7 
Fixes: #45502
PR-URL: #45519
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022
@Trott @marco-ippolito
test: revise pull request guide text about code
1c578b7 
Fixes: nodejs#45502
PR-URL: nodejs#45519
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@Trott @danielleadams
test: revise pull request guide text about code
56d612a 
Fixes: #45502
PR-URL: #45519
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@Trott @danielleadams
test: revise pull request guide text about code
8212eab 
Fixes: #45502
PR-URL: #45519
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@Trott @danielleadams
test: revise pull request guide text about code
305d4de 
Fixes: #45502
PR-URL: #45519
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@Trott @danielleadams
test: revise pull request guide text about code
c1f9ab5 
Fixes: #45502
PR-URL: #45519
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@Trott @danielleadams
test: revise pull request guide text about code
151ce0a 
Fixes: #45502
PR-URL: #45519
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@tniessen tniessen tniessen approved these changes

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unneded "." in pull-requests.md file
6 participants
@Trott @nodejs-github-bot @lpinca @tniessen @legendecas @anonrig