node-api: address coverity warning #45563
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
|
This is the report. I think technically it may be a false positive, but initializing the variable seems ok as well, so PR does that versus marking as false positive. / Create a new napi_env for this specific module.
634 napi_env env = v8impl::NewEnv(context, module_filename);
635
3. var_decl: Declaring variable _exports without initializer.
636 napi_value _exports;
637 env->CallIntoModule([&](napi_env env) {
638 _exports = init(env, v8impl::JsValueFromV8LocalValue(exports));
639 });
640
641 // If register function returned a non-null exports object different from
642 // the exports object we passed it, set that as the "exports" property of
643 // the module.
CID 276441 (#1 of 1): Uninitialized pointer read (UNINIT)
4. uninit_use: Using uninitialized value _exports.
644 if (_exports != nullptr &&
645 _exports != v8impl::JsValueFromV8LocalValue(exports)) {
646 napi_value _module = v8impl::JsValueFromV8LocalValue(module);
647 napi_set_named_property(env, _module, "exports", _exports);
648 } |
- address coverity unitialized variable warning Signed-off-by: Michael Dawson <mdawson@devrus.com>
mhdawson
force-pushed
the
coverity-25
branch
from
ba5c9de
to
3bab259
Compare
cjihrig
approved these changes
Nov 21, 2022
richardlau
approved these changes
Nov 21, 2022
daeyeon
added
author ready
daeyeon
approved these changes
Nov 22, 2022
Trott
changed the title
Trott
approved these changes
Nov 22, 2022
github-actions
bot
removed
the
request-ci
legendecas
approved these changes
Nov 22, 2022
lpinca
approved these changes
Nov 22, 2022
mhdawson
added a commit
that referenced
this pull request
Nov 24, 2022
- address coverity unitialized variable warning Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #45563 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in 0bbef56 |
ruyadorno
pushed a commit
that referenced
this pull request
Nov 24, 2022
- address coverity unitialized variable warning Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #45563 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
ErickWendel
pushed a commit
to ErickWendel/node
that referenced
this pull request
Nov 30, 2022
- address coverity unitialized variable warning Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#45563 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
- address coverity unitialized variable warning Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #45563 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
- address coverity unitialized variable warning Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #45563 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
- address coverity unitialized variable warning Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #45563 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 4, 2023
- address coverity unitialized variable warning Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #45563 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 5, 2023
- address coverity unitialized variable warning Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #45563 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Dawson mdawson@devrus.com