deps: V8: cherry-pick 2ada52cffbff #45573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
build
github-actions
bot
removed
the
request-ci
gengjiawen
approved these changes
Nov 22, 2022
richardlau
approved these changes
Nov 22, 2022
|
This will unblock #45068 from landing in LTS if we backport this as well? |
Yes, I suppose. |
cjihrig
approved these changes
Nov 22, 2022
13 tasks
|
@targos Can you rebase from main to solve the ASan CI issue? |
anonrig
approved these changes
Nov 23, 2022
Original commit message:
[intl] Enhance Date parser to take Unicode SPACE
This is needed to prepare for the landing of ICU72.
Allow U+202F in the Date String, which the toLocaleString("en-US")
will generate w/ ICU72.
Bug: v8:13494
Change-Id: I41b83c4094ce3d0737a72dcd6310b52c68fdcdca
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4027341
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jungshik Shin <jshin@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84308}
Refs: v8/v8@2ada52c
Fixes: nodejs#45171
github-actions
bot
removed
the
request-ci
16 tasks
gengjiawen
added
the
commit-queue
gengjiawen
added
commit-queue-failed
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/45573 ✔ Done loading data for nodejs/node/pull/45573 ----------------------------------- PR info ------------------------------------ Title deps: V8: cherry-pick 2ada52cffbff (#45573) Author Michaël Zasso (@targos) Branch targos:fix-45171 -> nodejs:main Labels build, v8 engine, needs-ci Commits 1 - deps: V8: cherry-pick 2ada52cffbff Committers 1 - Michaël Zasso PR-URL: https://github.com/nodejs/node/pull/45573 Fixes: https://github.com/nodejs/node/issues/45171 Refs: https://github.com/v8/v8/commit/2ada52cffbff11074abfaac18938bf02d85454f5 Reviewed-By: Jiawen Geng Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45573 Fixes: https://github.com/nodejs/node/issues/45171 Refs: https://github.com/v8/v8/commit/2ada52cffbff11074abfaac18938bf02d85454f5 Reviewed-By: Jiawen Geng Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - deps: V8: cherry-pick 2ada52cffbff ℹ This PR was created on Tue, 22 Nov 2022 08:21:45 GMT ✔ Approvals: 4 ✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/45573#pullrequestreview-1189584648 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/45573#pullrequestreview-1190006137 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/45573#pullrequestreview-1190051320 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45573#pullrequestreview-1191762773 ✖ Last GitHub CI failed ℹ Last Full PR CI on 2022-11-24T08:29:18Z: https://ci.nodejs.org/job/node-test-pull-request/48124/ - Querying data for job/node-test-pull-request/48124/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3538908052 |
gengjiawen
approved these changes
Nov 24, 2022
gengjiawen
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/45573 ✔ Done loading data for nodejs/node/pull/45573 ----------------------------------- PR info ------------------------------------ Title deps: V8: cherry-pick 2ada52cffbff (#45573) Author Michaël Zasso (@targos) Branch targos:fix-45171 -> nodejs:main Labels build, v8 engine, needs-ci Commits 1 - deps: V8: cherry-pick 2ada52cffbff Committers 1 - Michaël Zasso PR-URL: https://github.com/nodejs/node/pull/45573 Fixes: https://github.com/nodejs/node/issues/45171 Refs: https://github.com/v8/v8/commit/2ada52cffbff11074abfaac18938bf02d85454f5 Reviewed-By: Jiawen Geng Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45573 Fixes: https://github.com/nodejs/node/issues/45171 Refs: https://github.com/v8/v8/commit/2ada52cffbff11074abfaac18938bf02d85454f5 Reviewed-By: Jiawen Geng Reviewed-By: Richard Lau Reviewed-By: Colin Ihrig Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 22 Nov 2022 08:21:45 GMT ✔ Approvals: 4 ✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/45573#pullrequestreview-1192730622 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/45573#pullrequestreview-1190006137 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/45573#pullrequestreview-1190051320 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45573#pullrequestreview-1191762773 ✖ Last GitHub CI failed ℹ Last Full PR CI on 2022-11-24T08:43:44Z: https://ci.nodejs.org/job/node-test-pull-request/48124/ - Querying data for job/node-test-pull-request/48124/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3538908052 |
targos
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a972144 |
targos
added
lts-watch-v18.x
targos
added a commit
that referenced
this pull request
Nov 24, 2022
Original commit message:
[intl] Enhance Date parser to take Unicode SPACE
This is needed to prepare for the landing of ICU72.
Allow U+202F in the Date String, which the toLocaleString("en-US")
will generate w/ ICU72.
Bug: v8:13494
Change-Id: I41b83c4094ce3d0737a72dcd6310b52c68fdcdca
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4027341
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jungshik Shin <jshin@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84308}
Refs: v8/v8@2ada52c
Fixes: #45171
PR-URL: #45573
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
ruyadorno
pushed a commit
that referenced
this pull request
Nov 24, 2022
Original commit message:
[intl] Enhance Date parser to take Unicode SPACE
This is needed to prepare for the landing of ICU72.
Allow U+202F in the Date String, which the toLocaleString("en-US")
will generate w/ ICU72.
Bug: v8:13494
Change-Id: I41b83c4094ce3d0737a72dcd6310b52c68fdcdca
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4027341
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jungshik Shin <jshin@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84308}
Refs: v8/v8@2ada52c
Fixes: #45171
PR-URL: #45573
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Merged
This was referenced Nov 25, 2022
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
Original commit message:
[intl] Enhance Date parser to take Unicode SPACE
This is needed to prepare for the landing of ICU72.
Allow U+202F in the Date String, which the toLocaleString("en-US")
will generate w/ ICU72.
Bug: v8:13494
Change-Id: I41b83c4094ce3d0737a72dcd6310b52c68fdcdca
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4027341
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jungshik Shin <jshin@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84308}
Refs: v8/v8@2ada52c
Fixes: #45171
PR-URL: #45573
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: v8/v8@2ada52c
Fixes: #45171