Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix typos in test/parallel #45583

Merged
merged 1 commit into from Nov 28, 2022
Merged

test: fix typos in test/parallel #45583

merged 1 commit into from Nov 28, 2022

Conversation

deokjinkim
Copy link
Contributor

Fix typos in parallel tests.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 22, 2022
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 22, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 22, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48092/

@lpinca lpinca added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 22, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @lpinca. Please 👍 to approve.

@ErickWendel
Copy link
Member

I've just scheduled a Rerun for test-asan action as the error is not related to this PR. Let's check if it passes now 🤩

@cola119 cola119 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48160/

This was referenced Nov 25, 2022
Open
Open
Open
@deokjinkim
Copy link
Contributor Author

deokjinkim commented Nov 27, 2022 •
edited

@ErickWendel and @cola119, IMO, CI error is not related to this pr. Could you re-run CI when you are available?

@aduh95
Copy link
Contributor

aduh95 commented Nov 27, 2022

CI error is not related to this pr. Could you re-run CI when you are available?

The ASan CI is faulty on your branch (for a reason not related to this PR, indeed), the fix has landed in main so you would need to rebase your branch for the CI to turn green. Would you be able to do that? Let us know if you need help or if you would prefer someone else doing it for you.

@deokjinkim
test: fix typos in test/parallel
162fd7f 
Fix typos in parallel tests.
@deokjinkim
Copy link
Contributor Author

The ASan CI is faulty on your branch (for a reason not related to this PR, indeed), the fix has landed in main so you would need to rebase your branch for the CI to turn green. Would you be able to do that? Let us know if you need help or if you would prefer someone else doing it for you.

Thank you for kind explanation. I rebased this PR.

@aduh95 aduh95 removed the fast-track PRs that do not need to wait for 48 hours to land. label Nov 27, 2022
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 27, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 27, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48213/

@github-actions github-actions bot mentioned this pull request Nov 28, 2022
Open
20 tasks
@cola119 cola119 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 28, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 28, 2022
@nodejs-github-bot nodejs-github-bot merged commit 58b60c1 into nodejs:main Nov 28, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 58b60c1

This was referenced Nov 29, 2022
Open
Open
ErickWendel pushed a commit to ErickWendel/node that referenced this pull request Nov 30, 2022
@deokjinkim @ErickWendel
test: fix typos in test/parallel
ffdeefb 
Fix typos in parallel tests.

PR-URL: nodejs#45583
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
@github-actions github-actions bot mentioned this pull request Dec 1, 2022
Open
10 tasks
targos pushed a commit that referenced this pull request Dec 12, 2022
@deokjinkim @targos
test: fix typos in test/parallel
b55bd6e 
Fix typos in parallel tests.

PR-URL: #45583
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
@targos targos mentioned this pull request Dec 12, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@deokjinkim @danielleadams
test: fix typos in test/parallel
4b5c945 
Fix typos in parallel tests.

PR-URL: #45583
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@deokjinkim @danielleadams
test: fix typos in test/parallel
682a71c 
Fix typos in parallel tests.

PR-URL: #45583
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@deokjinkim @danielleadams
test: fix typos in test/parallel
7dbc742 
Fix typos in parallel tests.

PR-URL: #45583
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@deokjinkim @danielleadams
test: fix typos in test/parallel
14372b2 
Fix typos in parallel tests.

PR-URL: #45583
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@deokjinkim @danielleadams
test: fix typos in test/parallel
d3b2252 
Fix typos in parallel tests.

PR-URL: #45583
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@ErickWendel ErickWendel ErickWendel approved these changes

@aduh95 aduh95 aduh95 approved these changes

@cola119 cola119 cola119 approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@deokjinkim @nodejs-github-bot @ErickWendel @aduh95 @Trott @lpinca @cjihrig @richardlau @cola119 @RaisinTen