Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix cb scope bugs involved in termination #45596

Merged
merged 1 commit into from Feb 28, 2023
Merged

src: fix cb scope bugs involved in termination #45596

merged 1 commit into from Feb 28, 2023
+40 −3

Commits on Feb 20, 2023

  1. src: fix cb scope bugs involved in termination 

    Be more aggresive to clean up the async id stack,
and ensure the cleanup when terminating.

Calling SetIdle() when terminating is not harmless.
When node terminates due to an unhandled exception,
v8 preseves the vm state, which is JS and notifies
node through PerIsolateMessageListener(). If node
calls SetIdle() later, v8 complains because it
requires the vm state to either be EXTERNEL or IDLE
when embedder calling SetIdle().
    @ywave620
    ywave620 committed Feb 20, 2023
    Copy the full SHA
    af95ec8 View commit details
    Browse the repository at this point in the history