Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: improve robustness wrt to prototype pollution #45604

Merged
merged 1 commit into from Dec 14, 2022
Merged

repl: improve robustness wrt to prototype pollution #45604

merged 1 commit into from Dec 14, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 24, 2022

No description provided.

@nodejs-github-bot nodejs-github-bot added debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. util Issues and PRs related to the built-in util module. labels Nov 24, 2022
aduh95
aduh95 commented Nov 24, 2022
View reviewed changes
lib/internal/util.js Outdated Show resolved Hide resolved
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 14, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 14, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48464/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48470/

@aduh95 aduh95 merged commit 1c3ba4c into nodejs:main Dec 14, 2022
@aduh95 aduh95 deleted the robust-repl branch December 14, 2022 14:49
@aduh95
Copy link
Contributor Author

aduh95 commented Dec 14, 2022

Landed in 1c3ba4c

This was referenced Dec 15, 2022
Open
Open
Open
Open
targos pushed a commit that referenced this pull request Jan 1, 2023
@aduh95 @targos
repl: improve robustness wrt to prototype pollution
24cae6b 
PR-URL: #45604
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@aduh95 @juanarbol
repl: improve robustness wrt to prototype pollution
784ed59 
PR-URL: #45604
Reviewed-By: James M Snell <jasnell@gmail.com>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aduh95 @nodejs-github-bot @jasnell