Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: fix mock.method to support class instances #45608

Merged
merged 19 commits into from Dec 17, 2022
Merged

test_runner: fix mock.method to support class instances #45608

merged 19 commits into from Dec 17, 2022

Commits on Dec 6, 2022

  1. test: fix mock.method to support class instances 

    It fixes a problem when trying to spy a method
from a class instance or static functions
on a class instance
    @ErickWendel
    ErickWendel committed Dec 6, 2022
    Copy the full SHA
    c074724 View commit details
    Browse the repository at this point in the history

  2. added suggestions 

    Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
    @ErickWendel @anonrig
    ErickWendel and anonrig committed Dec 6, 2022
    Copy the full SHA
    495cebf View commit details
    Browse the repository at this point in the history

  3. test: remove unecessarly if 

    Signed-off-by: Erick Wendel <erick.workspace@gmail.com>
    @ErickWendel
    ErickWendel committed Dec 6, 2022
    Copy the full SHA
    e80de49 View commit details
    Browse the repository at this point in the history

  4. test: drop comments and rename tests 

    Signed-off-by: Erick Wendel <erick.workspace@gmail.com>
    @ErickWendel
    ErickWendel committed Dec 6, 2022
    Copy the full SHA
    628142e View commit details
    Browse the repository at this point in the history

  5. test_runner: ensure that mock.method works with class inheritance

    @ErickWendel
    ErickWendel committed Dec 6, 2022
    Copy the full SHA
    7fd649a View commit details
    Browse the repository at this point in the history

  6. test: ensure that the original object was reseted after execution

    @ErickWendel
    ErickWendel committed Dec 6, 2022
    Copy the full SHA
    1ff9a5f View commit details
    Browse the repository at this point in the history

  7. test_runner: added aduh95's suggestion to extend null

    @ErickWendel
    ErickWendel committed Dec 6, 2022
    Copy the full SHA
    7ca9a2b View commit details
    Browse the repository at this point in the history

  8. test_runner: remote proto.name validation on mock

    @ErickWendel
    ErickWendel committed Dec 6, 2022
    Copy the full SHA
    ef3188f View commit details
    Browse the repository at this point in the history

  9. test: fix lint

    @ErickWendel
    ErickWendel committed Dec 6, 2022
    Copy the full SHA
    8104c2a View commit details
    Browse the repository at this point in the history

  10. test_runner: added cjihrig suggestions to turn fns private

    @ErickWendel
    ErickWendel committed Dec 6, 2022
    Copy the full SHA
    73ca820 View commit details
    Browse the repository at this point in the history

  11. test_runner: validate properties in objects

    @ErickWendel
    ErickWendel committed Dec 6, 2022
    Copy the full SHA
    fe66804 View commit details
    Browse the repository at this point in the history

  12. test_runner: add colin's suggestion to simplify algorithm on mock

    @ErickWendel
    ErickWendel committed Dec 6, 2022
    Copy the full SHA
    e35911f View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. test_runner: turn fn into inline if 

    Signed-off-by: Erick Wendel <erick.workspace@gmail.com>
    @ErickWendel
    ErickWendel committed Dec 7, 2022
    Copy the full SHA
    92b68b4 View commit details
    Browse the repository at this point in the history

  2. test_runner: when method doesnt exists it shows a message

    @ErickWendel
    ErickWendel committed Dec 7, 2022
    Copy the full SHA
    9659cba View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2022

  1. add aduh95 suggestion test/parallel/test-runner-mocking.js 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @ErickWendel @aduh95
    ErickWendel and aduh95 committed Dec 12, 2022
    Copy the full SHA
    a6cebb6 View commit details
    Browse the repository at this point in the history

  2. test: assert by code instead of regex string

    @ErickWendel
    ErickWendel committed Dec 12, 2022
    Copy the full SHA
    c075f0e View commit details
    Browse the repository at this point in the history

  3. test_runner: rename object 

    Signed-off-by: Erick Wendel <erick.workspace@gmail.com>
    @ErickWendel
    ErickWendel committed Dec 12, 2022
    Copy the full SHA
    2edd34e View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. test_runner: add test case to check prototype chain 

    Signed-off-by: Erick Wendel <erick.workspace@gmail.com>
    @ErickWendel
    ErickWendel committed Dec 13, 2022
    Copy the full SHA
    f543e57 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. test: assert property descriptors

    @ErickWendel
    ErickWendel committed Dec 14, 2022
    Copy the full SHA
    152539d View commit details
    Browse the repository at this point in the history