Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v19.2.0 proposal #45615

Merged
merged 117 commits into from Nov 29, 2022
Merged

v19.2.0 proposal #45615

merged 117 commits into from Nov 29, 2022

Commits on Nov 21, 2022

  1. diagnostics_channel: mark as stable

    PR-URL: #45290
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Qard authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    44886e5 View commit details
    Browse the repository at this point in the history
  2. test: add a test to ensure the correctness of timezone upgrades

    Currently, there's no way to know if a timezone upgrade PR is correct
    without building and testing the change locally. This change provides a
    solution for that.
    
    Tested in RaisinTen#4.
    
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    PR-URL: #45299
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    RaisinTen authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    f79dd65 View commit details
    Browse the repository at this point in the history
  3. meta: be more proactive about removing from teams

    PR-URL: #45352
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Trott authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    6704e78 View commit details
    Browse the repository at this point in the history
  4. tools: dynamically determine parallelism on GitHub Actions macOS

    Refs: #45340 (comment)
    PR-URL: #45350
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Trott authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    7c6281a View commit details
    Browse the repository at this point in the history
  5. buffer: introduce File

    PR-URL: #45139
    Fixes: #39015
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    KhafraDev authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    6c56c97 View commit details
    Browse the repository at this point in the history
  6. deps: V8: cherry-pick 031b98b25cba

    Original commit message:
    
        [runtime] Clear array join stack when throwing uncatchable
    
        ... exception.
    
        Array#join depends array_join_stack to avoid infinite loop
        and ensures symmetric pushes/pops through catch blocks to
        correctly maintain the elements in the join stack.
        However, the stack does not pop the elements and leaves in
        an invalid state when throwing the uncatchable termination
        exception. And the invalid join stack state will affect
        subsequent Array#join calls. Because all the terminate
        exception will be handled by Isolate::UnwindAndFindHandler,
        we could clear the array join stack when unwinding the terminate
        exception.
    
        Bug: v8:13259
        Change-Id: I23823e823c5fe0b089528c5cf654864cea78ebeb
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3878451
        Reviewed-by: Jakob Linke <jgruber@chromium.org>
        Commit-Queue: 王澳 <wangao.james@bytedance.com>
        Cr-Commit-Position: refs/heads/main@{#83465}
    
    Refs: v8/v8@031b98b
    Closes: #44417
    PR-URL: #45375
    Fixes: #44417
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
    targos authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    17e6031 View commit details
    Browse the repository at this point in the history
  7. util: improve text decoder performance

    PR-URL: #45388
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    anonrig authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    f86f90f View commit details
    Browse the repository at this point in the history
  8. http: add JSDoc property descriptions

    PR-URL: #45370
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Trott authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    b72b2ba View commit details
    Browse the repository at this point in the history
  9. esm: add JSDoc property descriptions for fetch

    PR-URL: #45370
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Trott authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    4e5ad9d View commit details
    Browse the repository at this point in the history
  10. esm: add JSDoc property descriptions for loader

    PR-URL: #45370
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Trott authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    8906a4e View commit details
    Browse the repository at this point in the history
  11. tools: enable jsdoc/require-property-description rule

    PR-URL: #45370
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Trott authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    36bf87f View commit details
    Browse the repository at this point in the history
  12. tools: simplify regex in ESLint config

    PR-URL: #45399
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    b7f8a44 View commit details
    Browse the repository at this point in the history
  13. tools: simplify .eslintrc.js

    Remove explicit setting of configuration options in rules when those
    options are the defaults.
    
    PR-URL: #45397
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    93bc2ba View commit details
    Browse the repository at this point in the history
  14. tools: do not run CQ on non-fast-tracked PRs open for less than 2 days

    PR-URL: #45407
    Fixes: #45405
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    MoLow authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    bb36acf View commit details
    Browse the repository at this point in the history
  15. doc: fix typo in maintaining-dependencies.md

    PR-URL: #45428
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    tniessen authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    a6fe707 View commit details
    Browse the repository at this point in the history
  16. util: add fast path for utf8 encoding

    Co-authored-by: Anna Henningsen <anna@addaleax.net>
    PR-URL: #45412
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    2 people authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    7c79ba7 View commit details
    Browse the repository at this point in the history
  17. test: fix flaky test-repl-sigint-nested-eval

    There is a race condition where process.kill can be sent before the
    target is ready to receive the signal.
    
    Fixes: #41123
    PR-URL: #45354
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Trott authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    4fe5c4e View commit details
    Browse the repository at this point in the history
  18. src: condense experimental warning message

    PR-URL: #45424
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Trott authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    a483d12 View commit details
    Browse the repository at this point in the history
  19. tools: update lint-md-dependencies to rollup@3.3.0

    PR-URL: #45442
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    nodejs-github-bot authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    8a34ef4 View commit details
    Browse the repository at this point in the history
  20. watch: watch for missing dependencies

    PR-URL: #45348
    Reviewed-By: Ruy Adorno <ruyadorno@google.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
    MoLow authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    3263ceb View commit details
    Browse the repository at this point in the history
  21. doc: adjust wording to eliminate awkward typography

    PR-URL: #45398
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    kovsu authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    94a6a97 View commit details
    Browse the repository at this point in the history
  22. meta: update AUTHORS

    PR-URL: #45443
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    nodejs-github-bot authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    d13ea68 View commit details
    Browse the repository at this point in the history
  23. test_runner: support watch mode

    PR-URL: #45214
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    MoLow authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    e9760b4 View commit details
    Browse the repository at this point in the history
  24. build: make scripts in gyp run with right python

    PR-URL: #45435
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
    gengjiawen authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    1ce2f56 View commit details
    Browse the repository at this point in the history
  25. http: add debug log for ERR_UNESCAPED_CHARACTERS

    When encountering ERR_UNESCAPED_CHARACTERS on large applications it can
    be unclear which request has caused this error. Even when setting
    NODE_DEBUG=http there is no information about this error since it's
    thrown before any debug logs. This patch adds a debug log that contains
    the invalid path.
    
    PR-URL: #45420
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    aidant authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    f208db7 View commit details
    Browse the repository at this point in the history
  26. test: remove flaky designation for test-worker-http2-stream-terminate

    Closes: #43084
    PR-URL: #45438
    Fixes: #43084
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    00a3b5f View commit details
    Browse the repository at this point in the history
  27. tools: include current release in the list of released versions

    PR-URL: #45463
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    aduh95 authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    39e8731 View commit details
    Browse the repository at this point in the history
  28. deps: update acorn to 8.8.1

    PR-URL: #45441
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    nodejs-github-bot authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    ad8da86 View commit details
    Browse the repository at this point in the history
  29. doc: include v19.1.0 in CHANGELOG.md

    It was missed in the last release.
    
    Refs: 3770d3a
    PR-URL: #45462
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Ruy Adorno <ruyadorno@google.com>
    Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    RafaelGSS authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    4128c27 View commit details
    Browse the repository at this point in the history
  30. async_hooks: add hook to stop propagation

    Add hook to AsyncLocalStorage to allow user to stop propagation.
    This is needed to avoid leaking a store if e.g. the store indicates
    that its operations are finished or it reached its time to live.
    
    PR-URL: #45386
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Flarna authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    7cff1e1 View commit details
    Browse the repository at this point in the history
  31. src: add --max-semi-space-size to the options allowed in NODE_OPTIONS

    PR-URL: #44436
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    ehoogeveen-medweb authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    459d448 View commit details
    Browse the repository at this point in the history
  32. test: add test to validate changelogs for releases

    Add a new test to check that the changelog files have been correctly
    updated for releases.
    
    PR-URL: #45325
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    richardlau authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    51213c2 View commit details
    Browse the repository at this point in the history
  33. diagnostics_channel: built-in channels should remain experimental

    PR-URL: #45423
    Reviewed-By: theanarkh <theratliter@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Qard authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    9e0e97c View commit details
    Browse the repository at this point in the history
  34. test: update uses of _jabber._tcp.google.com

    _jabber._tcp.google.com seems to have stopped working. This
    commit changes the host to _caldav._tcp.google.com.
    
    Refs: denoland/deno_std#2881
    PR-URL: #45451
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    cjihrig authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    45b54ee View commit details
    Browse the repository at this point in the history
  35. deps: patch V8 to 10.7.193.22

    Refs: v8/v8@10.7.193.20...10.7.193.22
    PR-URL: #45460
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    targos authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    413bf9a View commit details
    Browse the repository at this point in the history
  36. deps: update zlib to upstream 8bbd6c31

    Updated as described in doc/contributing/maintaining-zlib.md.
    
    PR-URL: #45387
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    lpinca authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    c41e67f View commit details
    Browse the repository at this point in the history
  37. deps: fix zlib compilation for CPUs without SIMD features

    Fix the compile flags so that zlib can run on CPUs that do
    not have SSSE3/SSE4.2/etc. Do not compile zlib with flags that
    indicate that those features are available, and instead enable
    them selectively for functions that use them.
    
    There are probably better way to do this, e.g. through gyp file
    modifications as suggested in the issue. However, this patch
    should do just fine until that happens.
    
    Fixes: #32553
    
    PR-URL: #32627
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    PR-URL: #45387
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    addaleax authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    45ba14b View commit details
    Browse the repository at this point in the history
  38. deps: update timezone to 2022f

    PR-URL: #45289
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    nodejs-github-bot authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    628891d View commit details
    Browse the repository at this point in the history
  39. build: add --v8-disable-object-print flag

    --v8-enable-object-print flag is set by default true.
    so, no way of disable this flag.
    add a --v8-disable-object-print flag instead that defaults to false.
    
    Fixes: #45433
    PR-URL: #45458
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    fossamagna authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    62ef1eb View commit details
    Browse the repository at this point in the history
  40. test: add lint rule to enforce trailing commas

    Only activated on some subfolders to minimize the diff, ideally this
    rule would be applied gradually to the entire codebase in follow-up
    commits.
    
    PR-URL: #45468
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    aduh95 authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    1277ffc View commit details
    Browse the repository at this point in the history
  41. doc: add lint rule to enforce trailing commas

    PR-URL: #45471
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    aduh95 authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    1812a89 View commit details
    Browse the repository at this point in the history
  42. url: remove unnecessary object call to kFormat

    PR-URL: #45492
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    anonrig authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    bbba42f View commit details
    Browse the repository at this point in the history
  43. crypto: clear OpenSSL error queue after calling X509_verify()

    Prior to this commit, functions accessing the OpenSSL error queue did
    not work properly after x509.verify() returned false.
    
    PR-URL: #45377
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    takuro-sato authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    efe19eb View commit details
    Browse the repository at this point in the history
  44. doc: add arm64 to os.machine()

    PR-URL: #45374
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    sno2 authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    4de67d1 View commit details
    Browse the repository at this point in the history
  45. lib: do not throw if global property is no longer configurable

    Fixes: #45336
    PR-URL: #45344
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Jacob Smith <jacob@frende.me>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    38767b4 View commit details
    Browse the repository at this point in the history
  46. src: remove the unused PackageConfig class

    PR-URL: #45478
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    10e7c2a View commit details
    Browse the repository at this point in the history
  47. src: don't run tasks on isolate termination

    Fixes: #45419
    PR-URL: #45444
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    santigimeno authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    5e5bf0c View commit details
    Browse the repository at this point in the history
  48. meta: update VoltrexMaster's username

    Update VoltrexMaster's GitHub username to the new one.
    
    PR-URL: #45503
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    VoltrexKeyva authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    208ea1a View commit details
    Browse the repository at this point in the history
  49. fs: fix fs.rm support for loop symlinks

    Fixes: #45404
    PR-URL: #45439
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    nathanael-ruf authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    2b760c3 View commit details
    Browse the repository at this point in the history
  50. node-api: fix immediate napi_remove_wrap test

    As documented in napi_wrap section, the returned reference must be
    deleted with `napi_delete_reference` in response to the finalize
    callback, in which `napi_unwrap` and `napi_remove_wrap` is not
    available.
    
    When the reference needs to be deleted early, it should be
    deleted after the wrapped value is not accessed with `napi_unwrap`
    and `napi_remove_wrap` too.
    
    This test is previously added in response to duplicating the test
    https://github.com/nodejs/node-addon-api/blob/main/test/objectwrap_constructor_exception.cc
    in the node-addon-api. As Napi::ObjectWrap<> is a subclass of
    Napi::Reference<>, napi_remove_wrap in the destructor of
    Napi::ObjectWrap<> is called before napi_delete_reference in the
    destructor of Napi::Reference<>.
    
    PR-URL: #45406
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    legendecas authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    8ff16fd View commit details
    Browse the repository at this point in the history
  51. deps: V8: cherry-pick 9df5ef70ff18

    Original commit message:
    
        Add an `v8::ArrayBuffer::WasDetached` method to the C++ API
    
        V8's C++ API does not give a way to tell whether an ArrayBuffer has
        been detached from the `v8::ArrayBuffer` class. In fact, as far as can
        be told from the C++ API without running JS code, detached
        ArrayBuffers behave the same as zero-sized ArrayBuffers and there is
        no way to observe the difference. However, this difference can be
        observed in JS because constructing a TypedArray from a detached
        ArrayBuffer will throw.
    
        This change adds a `WasDetached` method to the `v8::ArrayBuffer` class
        to give embedders access to this information without having to run JS
        code.
    
        Bug: v8:13159
        Change-Id: I2bb1e380cee1cecd31f6d48ec3d9f28c03a8a673
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3810345
        Commit-Queue: Toon Verwaest <verwaest@chromium.org>
        Reviewed-by: Toon Verwaest <verwaest@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#83963}
    
    Refs: v8/v8@9df5ef7
    PR-URL: #45474
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    anonrig authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    117efe9 View commit details
    Browse the repository at this point in the history
  52. test: enable the WPT for structuredClone

    So far, all `structuredClone` tests have been just skipped.
    
    Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
    PR-URL: #45482
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    daeyeon authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    b491504 View commit details
    Browse the repository at this point in the history
  53. stream: add fast path for utf8

    PR-URL: #45483
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    anonrig authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    8d96e2c View commit details
    Browse the repository at this point in the history
  54. Revert "build: remove precompiled header and debug information for ho…

    …st builds"
    
    This reverts commit 818284b.
    
    Reverted commit is a no longer needed patch for ARM64 cross-compiling.
    It was increasing cross-compile time drastically (~3 times longer).
    
    PR-URL: #45432
    Refs: #42538
    Refs: #42375
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Stewart X Addison <sxa@redhat.com>
    StefanStojanovic authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    0f3cf7e View commit details
    Browse the repository at this point in the history
  55. benchmark: add text-encoder benchmark

    PR-URL: #45450
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    anonrig authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    26ad54c View commit details
    Browse the repository at this point in the history
  56. tools: update certdata.txt

    This is the certdata.txt[0] from NSS 3.85, released on 2022-11-10.
    
    This is the version of NSS that will ship in Firefox 108 on
    2022-12-13.
    
    [0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_85_RTM/lib/ckfw/builtins/certdata.txt
    
    PR-URL: #45490
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    lpinca authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    cca2033 View commit details
    Browse the repository at this point in the history
  57. crypto: update root certificates

    Update the list of root certificates in src/node_root_certs.h with
    tools/mk-ca-bundle.pl.
    
    Certificates added:
    - Autoridad de Certificacion Firmaprofesional CIF A62634068
    - Certainly Root E1
    - Certainly Root R1
    - D-TRUST BR Root CA 1 2020
    - D-TRUST EV Root CA 1 2020
    - DigiCert TLS ECC P384 Root G5
    - DigiCert TLS RSA4096 Root G5
    - E-Tugra Global Root CA ECC v3
    - E-Tugra Global Root CA RSA v3
    - HiPKI Root CA - G1
    - ISRG Root X2
    - Security Communication ECC RootCA1
    - Security Communication RootCA3
    - Telia Root CA v2
    - vTrus ECC Root CA
    - vTrus Root CA
    
    Certificates removed:
    - Cybertrust Global Root
    - DST Root CA X3
    - GlobalSign Root CA - R2
    - Hellenic Academic and Research Institutions RootCA 2011
    
    PR-URL: #45490
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    lpinca authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    724addb View commit details
    Browse the repository at this point in the history
  58. trace_events: add new categories

    PR-URL: #45266
    Refs: #45092
    Refs: #44458
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    theanarkh authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    f441b04 View commit details
    Browse the repository at this point in the history
  59. deps: update V8 to 10.8.168.20

    PR-URL: #45230
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    targos authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    a3b9967 View commit details
    Browse the repository at this point in the history
  60. build: reset embedder string to "-node.0"

    PR-URL: #45230
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    targos authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    54fd8a1 View commit details
    Browse the repository at this point in the history
  61. deps: fix V8 build issue with inline methods

    PR-URL: #35415
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    
    deps: patch for v8 on windows
    
    PR-URL: #40010
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    
    deps: patch v8 for vs2019 in std17
    
    PR-URL: #40060
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    
    deps: workaround debug link error on Windows
    
    PR-URL: #38807
    Refs: #38788
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ash Cripps <acripps@redhat.com>
    PR-URL: #45230
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    gengjiawen authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    e929254 View commit details
    Browse the repository at this point in the history
  62. deps: V8: fix v8-cppgc.h for MSVC

    Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661
    Refs: #42375
    
    PR-URL: #42657
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    PR-URL: #45230
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    gengjiawen authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    9348bdd View commit details
    Browse the repository at this point in the history
  63. deps: silence irrelevant V8 warning

    PR-URL: #44741
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    PR-URL: #45230
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    targos authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    3cd6367 View commit details
    Browse the repository at this point in the history
  64. deps: fix V8 build on Windows with MSVC

    PR-URL: #44741
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    PR-URL: #45230
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    targos authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    1370b1a View commit details
    Browse the repository at this point in the history
  65. deps: V8: cherry-pick 92a7385171bb

    Original commit message:
    
        [heap] Fix 32bit msvc builds
    
        Size of ActiveSystemPages is 8 bytes even on 32bit builds, thus
        forcing 8 bytes alignment for MemoryChunk.
    
        Change-Id: I5ca1e18329d6e68a8b6811c3c27cb224c765cb63
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3966953
        Commit-Queue: Omer Katz <omerkatz@chromium.org>
        Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#83845}
    
    Refs: v8/v8@92a7385
    PR-URL: #45230
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    targos authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    51eb323 View commit details
    Browse the repository at this point in the history
  66. deps: V8: cherry-pick f1c888e7093e

    Original commit message:
    
        [base] Fix SmartOS build
    
        That platform doesn't have `malloc_usable_size`.
    
        Refs: nodejs/node-v8#239
        Change-Id: I011dd8449d02b27219a32cba00132cd068069f50
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4026402
        Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
        Commit-Queue: Michaël Zasso <mic.besace@gmail.com>
        Cr-Commit-Position: refs/heads/main@{#84256}
    
    Refs: v8/v8@f1c888e
    PR-URL: #45230
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    targos authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    e70c309 View commit details
    Browse the repository at this point in the history
  67. deps: V8: cherry-pick 9df5ef70ff18

    Original commit message:
    
        Add an `v8::ArrayBuffer::WasDetached` method to the C++ API
    
        V8's C++ API does not give a way to tell whether an ArrayBuffer has
        been detached from the `v8::ArrayBuffer` class. In fact, as far as can
        be told from the C++ API without running JS code, detached
        ArrayBuffers behave the same as zero-sized ArrayBuffers and there is
        no way to observe the difference. However, this difference can be
        observed in JS because constructing a TypedArray from a detached
        ArrayBuffer will throw.
    
        This change adds a `WasDetached` method to the `v8::ArrayBuffer` class
        to give embedders access to this information without having to run JS
        code.
    
        Bug: v8:13159
        Change-Id: I2bb1e380cee1cecd31f6d48ec3d9f28c03a8a673
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3810345
        Commit-Queue: Toon Verwaest <verwaest@chromium.org>
        Reviewed-by: Toon Verwaest <verwaest@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#83963}
    
    Refs: v8/v8@9df5ef7
    PR-URL: #45474
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    PR-URL: #45230
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    anonrig authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    aaa4ac7 View commit details
    Browse the repository at this point in the history
  68. test: adapt test-v8-stats for V8 update

    PR-URL: #45230
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    targos authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    72f2df2 View commit details
    Browse the repository at this point in the history
  69. test: fix test-trace-gc-flag

    PR-URL: #45230
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    tony-go authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    076e9ee View commit details
    Browse the repository at this point in the history
  70. stream: fix typo in adapters.js (#45515)

    `isReadableNodestream` -> `isReadableNodeStream`
    
    PR-URL: #45515
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    cola119 authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    496912d View commit details
    Browse the repository at this point in the history
  71. crypto: clear OpenSSL error queue after calling X509_check_private_key()

    Fixes: #45485
    PR-URL: #45495
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    panva authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    bd3accc View commit details
    Browse the repository at this point in the history
  72. gyp: fix v8 canary build on aix

    PR-URL: #45496
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    V-for-Vasili authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    e0a271e View commit details
    Browse the repository at this point in the history
  73. node-api: declare type napi_cleanup_hook

    Declare type `napi_cleanup_hook` so that the function signature can be
    shared across the codebase.
    
    PR-URL: #45391
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    legendecas authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    4a4f280 View commit details
    Browse the repository at this point in the history
  74. src: move FsStatsOffset and kFsStatsBufferLength to node_file.h

    To avoid bloating env.h, as they are only used in node_file.*
    
    PR-URL: #45498
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    cce9e11 View commit details
    Browse the repository at this point in the history
  75. Revert "url: improve port validation"

    This reverts commit 5f7730e.
    
    This change broke too many edge cases in the ecosystem. Reverting it
    re-introduces some host-spoofing possibilities, so we won't want to
    revert forever, but the issue is long-lived enough and not sufficiently
    critical that we can't wait for a major release to introduce it as a
    breaking change. After this lands, I plan to re-introduce this as a
    change that throws a warning rather than an error, after which we can
    land a semver-major that re-introduces the error and try to get the word
    out to maintainers of likely-affected packages.
    
    Closes: #45514
    Refs: #45012
    PR-URL: #45517
    Fixes: #45514
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Trott authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    6bdd2c3 View commit details
    Browse the repository at this point in the history
  76. test: revise pull request guide text about code

    Fixes: #45502
    PR-URL: #45519
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Trott authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    c9ba0b7 View commit details
    Browse the repository at this point in the history
  77. meta: update AUTHORS

    PR-URL: #45531
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    0d1b1c5 View commit details
    Browse the repository at this point in the history
  78. module: require.resolve.paths returns null with node schema

    require.resolve.paths should returns null with builtin module.
    when builtin module without `node:` schema, `paths` returns null.
    But, it don't return null when builtin module with `node:` schema.
    
    Fixes: #45001
    PR-URL: #45147
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    fossamagna authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    6fdd202 View commit details
    Browse the repository at this point in the history
  79. doc: fix RESOLVE_ESM_MATCH in modules.md

    Return type of PACKAGE_EXPORTS_RESOLVE was changed when subpath folder
    mappings reached EOL. But RESOLVE_ESM_MATCH was not updated.
    
    Refs: #40121
    PR-URL: #45280
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    sapphi-red authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    118de4b View commit details
    Browse the repository at this point in the history
  80. tools: add missing step in update-base64.sh script

    PR-URL: #45509
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    facutuesca authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    d4f30f0 View commit details
    Browse the repository at this point in the history
  81. deps: update base64 to 0.5.0

    PR-URL: #45509
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    facutuesca authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    43e002e View commit details
    Browse the repository at this point in the history
  82. stream: avoid premature close when will not emit close

    Fixes: #45281
    PR-URL: #45301
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    ronag authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    5274a8f View commit details
    Browse the repository at this point in the history
  83. stream: add primordials to adapters

    PR-URL: #45511
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    anonrig authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    c00258e View commit details
    Browse the repository at this point in the history
  84. doc: add async_hooks migration note

    PR-URL: #45335
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    GeoffreyBooth authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    6f0bc09 View commit details
    Browse the repository at this point in the history
  85. src: set an appropriate thread pool size if given --v8-pool-size=0

    It doesn't terminate when any pending V8 tasks exist if no thread
    is in the pool.
    
    This allocates one thread at least for V8's background tasks if
    `--v8-pool-size=0` is given as a CLI option.
    
    Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
    PR-URL: #45513
    Fixes: #42523
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    daeyeon authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    56f22ea View commit details
    Browse the repository at this point in the history
  86. doc: run license-builder

    PR-URL: #45553
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    github-actions[bot] authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    19d8493 View commit details
    Browse the repository at this point in the history
  87. build: fix env.h for cpp20

    Co-authored-by: joyeecheung <joyeec9h3@gmail.com>
    PR-URL: #45516
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    2 people authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    5c9b2a7 View commit details
    Browse the repository at this point in the history
  88. doc: add Node.js Threat Model

    Co-authored-by: Michael Dawson <midawson@redhat.com>
    Co-authored-by: Facundo Tuesca <facundo.tuesca@trailofbits.com>
    Co-authored-by: Ulises Gascon <UlisesGascon@users.noreply.github.com>
    Co-authored-by: Thomas Gentilhomme <gentilhomme.thomas@gmail.com>
    PR-URL: #45223
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    5 people authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    5b1df22 View commit details
    Browse the repository at this point in the history
  89. doc: fix typo in threat model

    Refs: #45223
    PR-URL: #45558
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    tniessen authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    246cd35 View commit details
    Browse the repository at this point in the history
  90. test: add trailing commas in test/common (#45550)

    PR-URL: #45550
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    aduh95 authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    d6c68ce View commit details
    Browse the repository at this point in the history
  91. test: add trailing commas in addons test (#45548)

    PR-URL: #45548
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    aduh95 authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    731e874 View commit details
    Browse the repository at this point in the history
  92. test: add trailing commas in async-hooks tests (#45549)

    PR-URL: #45549
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    aduh95 authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    bb4c293 View commit details
    Browse the repository at this point in the history
  93. tools: add automation for updating libuv dependency

    Add a Github Action that checks for new versions of the `libuv` C
    library, and creates a PR to update it if a newer version than the one
    present in the repo is found.
    
    Refs: nodejs/security-wg#828
    PR-URL: #45362
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    facutuesca authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    f3f1aed View commit details
    Browse the repository at this point in the history
  94. benchmark: add v8 serialize benchmark

    PR-URL: #45476
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    anonrig authored and ruyadorno committed Nov 21, 2022
    Copy the full SHA
    f08f6a6 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2022

  1. doc: add missing documentation for paramEncoding

    This option has existed ever since generateKeyPair was added in 2019 or
    so, but I apparently forgot to document it.
    
    PR-URL: #45523
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    tniessen authored and ruyadorno committed Nov 24, 2022
    Copy the full SHA
    16643db View commit details
    Browse the repository at this point in the history
  2. lib: improve AbortController creation duration

    PR-URL: #45525
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    anonrig authored and ruyadorno committed Nov 24, 2022
    Copy the full SHA
    5745bcb View commit details
    Browse the repository at this point in the history
  3. lib: improve transferable abort controller exec

    PR-URL: #45525
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    anonrig authored and ruyadorno committed Nov 24, 2022
    Copy the full SHA
    4c9159a View commit details
    Browse the repository at this point in the history
  4. Revert "http: headers(Distinct), trailers(Distinct) setters to be no-op"

    This reverts commit 4d723c7.
    
    I'm not sure if we should re-apply this as a semver-major change or if
    we should accept it as valid and add tests/documentation, but either
    way, we have to revert it at least temporarily.
    
    Closes: #45510
    PR-URL: #45527
    Fixes: #45510
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Trott authored and ruyadorno committed Nov 24, 2022
    Copy the full SHA
    eac26c0 View commit details
    Browse the repository at this point in the history
  5. stream: use ArrayBufferPrototypeGetByteLength

    PR-URL: #45528
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    anonrig authored and ruyadorno committed Nov 24, 2022
    Copy the full SHA
    f720c58 View commit details
    Browse the repository at this point in the history
  6. test_runner: add initial TAP parser

    Work in progress
    
    PR-URL: #43525
    Refs: #43344
    Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    manekinekko authored and ruyadorno committed Nov 24, 2022
    Copy the full SHA
    016749b View commit details
    Browse the repository at this point in the history
  7. doc: add version description about fsPromise.constants

    PR-URL: #45556
    Refs: #43177
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    lvqq authored and ruyadorno committed Nov 24, 2022
    Copy the full SHA
    4345732 View commit details
    Browse the repository at this point in the history
  8. tools: update eslint to 8.28.0

    PR-URL: #45532
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    nodejs-github-bot authored and ruyadorno committed Nov 24, 2022
    Copy the full SHA
    81f63c2 View commit details
    Browse the repository at this point in the history
  9. src,node-api: update napi_is_detached_arraybuffer

    This gets `napi_is_detached_arraybuffer(..)` to use the new API,
    `ArrayBuffer::WasDetached`, that looks more straightforward.
    
    Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
    PR-URL: #45538
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    daeyeon authored and ruyadorno committed Nov 24, 2022
    Copy the full SHA
    42507e6 View commit details
    Browse the repository at this point in the history
  10. build,deps,src: fix Intel VTune profiling support

    PR-URL: #45248
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    lucshi authored and ruyadorno committed Nov 24, 2022
    Copy the full SHA
    9ffe3c0 View commit details
    Browse the repository at this point in the history
  11. src: add missing include for std::all_of

    This fixes compilation of src/inspector_socket.cc with clang-cl.
    
    PR-URL: #45541
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    targos authored and ruyadorno committed Nov 24, 2022
    Copy the full SHA
    649b31f View commit details
    Browse the repository at this point in the history
  12. src: avoid unused variables and functions

    PR-URL: #45542
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    targos authored and ruyadorno committed Nov 24, 2022
    Copy the full SHA
    57bca94 View commit details
    Browse the repository at this point in the history
  13. build: avoid redefined macro

    It's already defined in `common.gypi`.
    
    PR-URL: #45544
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    targos authored and ruyadorno committed Nov 24, 2022
    Copy the full SHA
    6e1e25d View commit details
    Browse the repository at this point in the history
  14. tools: have test-asan use ubuntu-20.04

    PR-URL: #45581
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    panva authored and ruyadorno committed Nov 24, 2022
    Copy the full SHA
    160c88e View commit details
    Browse the repository at this point in the history
  15. test: add trailing commas in event tests

    As much as I would like to do this everywhere and then modify the lint
    rule to enforce it, the churn would be too big. However if we're going
    to have relatively frequent nits for this sort of thing (as we do), I'd
    prefer we migrate a few files at a time to never actually getting around
    to doing it.
    
    Ref: #45448 (review)
    PR-URL: #45466
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Trott authored and ruyadorno committed Nov 24, 2022
    Copy the full SHA
    c3fe907 View commit details
    Browse the repository at this point in the history
  16. doc: use console.error for error case in http2

    console.error is more suitable than console.log for error case.
    
    PR-URL: #45577
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    deokjinkim authored and ruyadorno committed Nov 24, 2022
    Copy the full SHA
    015842f View commit details
    Browse the repository at this point in the history
  17. src: use qualified std::move call in node_http2

    Also iwyu in that file.
    
    Closes: #45543
    PR-URL: #45555
    Fixes: #45543
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    targos authored and ruyadorno committed Nov 24, 2022
    Copy the full SHA
    128c9f6 View commit details
    Browse the repository at this point in the history
  18. doc: clarify changes in readableFlowing

    PR-URL: #45554
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    cola119 authored and ruyadorno committed Nov 24, 2022
    Copy the full SHA
    d805d5a View commit details
    Browse the repository at this point in the history
  19. deps: V8: cherry-pick 2ada52cffbff

    Original commit message:
    
        [intl] Enhance Date parser to take Unicode SPACE
    
        This is needed to prepare for the landing of ICU72.
        Allow U+202F in the Date String, which the toLocaleString("en-US")
        will generate w/ ICU72.
    
        Bug: v8:13494
        Change-Id: I41b83c4094ce3d0737a72dcd6310b52c68fdcdca
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4027341
        Reviewed-by: Yang Guo <yangguo@chromium.org>
        Reviewed-by: Jungshik Shin <jshin@chromium.org>
        Commit-Queue: Frank Tang <ftang@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#84308}
    
    Refs: v8/v8@2ada52c
    Fixes: #45171
    PR-URL: #45573
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    targos authored and ruyadorno committed Nov 24, 2022
    Copy the full SHA
    f63ae52 View commit details
    Browse the repository at this point in the history
  20. doc: deprecate use of invalid ports in url.parse

    PR-URL: #45576
    Refs: #45526
    Co-authored-by: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    2 people authored and ruyadorno committed Nov 24, 2022
    Copy the full SHA
    b6b5b51 View commit details
    Browse the repository at this point in the history
  21. node-api: address coverity warning

    - address coverity unitialized variable warning
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #45563
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    mhdawson authored and ruyadorno committed Nov 24, 2022
    Copy the full SHA
    38f1ede View commit details
    Browse the repository at this point in the history
  22. src: address coverity warning in node_file.cc

    Address coverity warning that looks like
    it identifies a potential crash due to using
    a value after it's been passed into std::move
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #45565
    Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    mhdawson authored and ruyadorno committed Nov 24, 2022
    Copy the full SHA
    e7a5b33 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2022

  1. 2022-11-29, Version 19.2.0 (Current)

    Notable changes:
    
    buffer:
      * (SEMVER-MINOR) introduce File (Khafra) #45139
    deps:
      * update timezone to 2022f (Node.js GitHub Bot) #45289
      * update V8 to 10.8.168.20 (Michaël Zasso) #45230
    doc:
      * deprecate use of invalid ports in `url.parse` (Antoine du Hamel) #45576
    util:
      * add fast path for utf8 encoding (Yagiz Nizipli) #45412
    
    PR-URL: #45615
    ruyadorno committed Nov 25, 2022
    Copy the full SHA
    8a4d7ac View commit details
    Browse the repository at this point in the history