Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add missing line in debugger #45632

Merged

Conversation

deokjinkim
Copy link
Contributor

Output of "node inspect" missed "connecting to..." line from time to time.
So added it.

Output of "node inspect" missed "connecting to..."
line from time to time. So added it.
@nodejs-github-bot nodejs-github-bot added debugger Issues and PRs related to the debugger subsystem. doc Issues and PRs related to the documentations. labels Nov 26, 2022
Copy link
Member

@cola119 cola119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cola119 cola119 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 27, 2022
@cola119 cola119 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 30, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 30, 2022
@nodejs-github-bot nodejs-github-bot merged commit 1b550ba into nodejs:main Nov 30, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 1b550ba

ErickWendel pushed a commit to ErickWendel/node that referenced this pull request Nov 30, 2022
Output of "node inspect" missed "connecting to..."
line from time to time. So added it.

PR-URL: nodejs#45632
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Dec 12, 2022
Output of "node inspect" missed "connecting to..."
line from time to time. So added it.

PR-URL: #45632
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
Output of "node inspect" missed "connecting to..."
line from time to time. So added it.

PR-URL: #45632
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
Output of "node inspect" missed "connecting to..."
line from time to time. So added it.

PR-URL: #45632
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
Output of "node inspect" missed "connecting to..."
line from time to time. So added it.

PR-URL: #45632
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
Output of "node inspect" missed "connecting to..."
line from time to time. So added it.

PR-URL: #45632
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
Output of "node inspect" missed "connecting to..."
line from time to time. So added it.

PR-URL: #45632
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. debugger Issues and PRs related to the debugger subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants