Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16.x backport] src: let http2 streams end after session close #45660

Closed
wants to merge 1 commit into from

Commits on Nov 29, 2022

  1. src: let http2 streams end after session close

    After the stream has been marked as closed by the nghttp2 stack, there
    might be still pending data to be sent: trailing headers is an example
    of this. In that case, avoid reentering the nghttp2 stack synchronously
    to allow the data to be written before actually closing the stream.
    
    Fixes: nodejs#42713
    PR-URL: nodejs#45153
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    (cherry picked from commit 71bdecb)
    santigimeno authored and adamrdavid committed Nov 29, 2022
    Copy the full SHA
    8bb8590 View commit details
    Browse the repository at this point in the history