Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: check number of arguments in EventTarget's function #45668

Merged
merged 4 commits into from Dec 9, 2022
Merged

lib: check number of arguments in EventTarget's function #45668

merged 4 commits into from Dec 9, 2022

Commits on Dec 1, 2022

  1. lib: check number of arguments in EventTarget's function 

    For now, addEventListener() only checks number of arguments.
removeEventListener() and dispatchEvent() also need checking
number of arguments.
    @deokjinkim
    deokjinkim committed Dec 1, 2022
    Copy the full SHA
    6860e13 View commit details
    Browse the repository at this point in the history

  2. remove validating error message in test case

    @deokjinkim
    deokjinkim committed Dec 1, 2022
    Copy the full SHA
    cc631b2 View commit details
    Browse the repository at this point in the history

  3. Update test/parallel/test-eventtarget.js 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @deokjinkim @aduh95
    deokjinkim and aduh95 committed Dec 1, 2022
    Copy the full SHA
    a53c721 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review

    @aduh95
    aduh95 committed Dec 1, 2022
    Copy the full SHA
    6cdded5 View commit details
    Browse the repository at this point in the history