Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: Make OutgoingMessage more streamlike #45672

Merged
merged 10 commits into from Dec 2, 2022
Merged

http: Make OutgoingMessage more streamlike #45672

merged 10 commits into from Dec 2, 2022

Commits on Nov 29, 2022

  1. http: Make OutgoingMessage more streamlike 

    Implement missing getters error & closed. Add support for
proper "writable" check through isWritable helper.

We cannot fix the OutgoingMessage.writable propery as that
will break the ecosystem.
    @ronag
    ronag committed Nov 29, 2022
    Copy the full SHA
    1047db4 View commit details
    Browse the repository at this point in the history

  2. fixup

    @ronag
    ronag committed Nov 29, 2022
    Copy the full SHA
    7813900 View commit details
    Browse the repository at this point in the history

  3. fixup

    @ronag
    ronag committed Nov 29, 2022
    Copy the full SHA
    8d247a5 View commit details
    Browse the repository at this point in the history

  4. fixuP

    @ronag
    ronag committed Nov 29, 2022
    Copy the full SHA
    e0a4a31 View commit details
    Browse the repository at this point in the history

  5. fixuP

    @ronag
    ronag committed Nov 29, 2022
    Copy the full SHA
    c9a76ba View commit details
    Browse the repository at this point in the history

  6. fixup: tests

    @ronag
    ronag committed Nov 29, 2022
    Copy the full SHA
    2a412af View commit details
    Browse the repository at this point in the history

  7. fiuxp

    @ronag
    ronag committed Nov 29, 2022
    Copy the full SHA
    3b3fbb5 View commit details
    Browse the repository at this point in the history

  8. fiuxp

    @ronag
    ronag committed Nov 29, 2022
    Copy the full SHA
    25d952b View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @ronag @aduh95
    ronag and aduh95 committed Nov 30, 2022
    Copy the full SHA
    305ade0 View commit details
    Browse the repository at this point in the history

  2. fixup

    @ronag
    ronag committed Nov 30, 2022
    Copy the full SHA
    fd82016 View commit details
    Browse the repository at this point in the history