Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: make structuredClone work for process.env #45698

Merged
merged 1 commit into from Dec 11, 2022
Merged

src: make structuredClone work for process.env #45698

merged 1 commit into from Dec 11, 2022

Conversation

bnoordhuis
Copy link
Member

Fixes: #45380

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Dec 1, 2022
@bnoordhuis bnoordhuis mentioned this pull request Dec 1, 2022
Closed
addaleax
addaleax reviewed Dec 2, 2022
View reviewed changes
src/node_env_var.cc Outdated Show resolved Hide resolved
src/node_messaging.cc Outdated Show resolved Hide resolved
src/node_messaging.cc Outdated Show resolved Hide resolved
@bnoordhuis
Copy link
Member Author

Thanks for the review, Anna. PTAL if you have a moment.

@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48317/

@github-actions github-actions bot mentioned this pull request Dec 8, 2022
Open
8 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48346/

This was referenced Dec 9, 2022
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48398/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 10, 2022
@github-actions github-actions bot mentioned this pull request Dec 11, 2022
Open
11 tasks
@addaleax addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 11, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 11, 2022
@nodejs-github-bot nodejs-github-bot merged commit 8273320 into nodejs:main Dec 11, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 8273320

@github-actions github-actions bot mentioned this pull request Dec 12, 2022
Open
11 tasks
ErickWendel pushed a commit to ErickWendel/node that referenced this pull request Dec 12, 2022
@bnoordhuis @ErickWendel
src: make structuredClone work for process.env
9ec53ba 
Fixes: nodejs#45380
PR-URL: nodejs#45698
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos pushed a commit that referenced this pull request Dec 12, 2022
@bnoordhuis @targos
src: make structuredClone work for process.env
a172601 
Fixes: #45380
PR-URL: #45698
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@targos targos mentioned this pull request Dec 12, 2022
Merged
@github-actions github-actions bot mentioned this pull request Dec 13, 2022
Open
13 tasks
targos pushed a commit that referenced this pull request Dec 13, 2022
@bnoordhuis @targos
src: make structuredClone work for process.env
b35ebeb 
Fixes: #45380
PR-URL: #45698
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@bnoordhuis @danielleadams
src: make structuredClone work for process.env
bb26dae 
Fixes: #45380
PR-URL: #45698
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@bnoordhuis @danielleadams
src: make structuredClone work for process.env
b99e77b 
Fixes: #45380
PR-URL: #45698
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@bnoordhuis @danielleadams
src: make structuredClone work for process.env
b88ee54 
Fixes: #45380
PR-URL: #45698
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@bnoordhuis @danielleadams
src: make structuredClone work for process.env
8f736a1 
Fixes: #45380
PR-URL: #45698
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@bnoordhuis @danielleadams
src: make structuredClone work for process.env
f995a06 
Fixes: #45380
PR-URL: #45698
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

structuredClone does not work on process.env
4 participants
@bnoordhuis @nodejs-github-bot @addaleax @anonrig