Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: disable v8 snapshot compression #45716

Closed

Commits on Dec 8, 2022

  1. build: disable v8 snapshot compression by default

    In the upstream, V8 also disables snapshot compression on the
    desktop by default because the size reduction is not worth the
    performance hit.
    https://chromium-review.googlesource.com/c/v8/v8/+/3275554
    
    Locally the binary size of Node.js is increased by ~2.7MB
    (+3.2%) with a significant speedup in startup after snapshot
    compression is disabled on macOS.
    
    Also adds a --v8-enable-snapshot-compression to configure.py for
    users who prefer a size reduction over speedup in startup.
    Ideally we should implement our own compression for the source
    code + the code cache + the snapshot instead of relying on V8's
    builtin compression for just the snapshot.
    joyeecheung committed Dec 8, 2022
    Copy the full SHA
    461c97d View commit details
    Browse the repository at this point in the history