Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move test file to sequential/ due to timing issues #45722

Merged
merged 1 commit into from May 11, 2024
Merged

test: move test file to sequential/ due to timing issues #45722

merged 1 commit into from May 11, 2024

Conversation

sonimadhuri
Copy link
Contributor

@sonimadhuri sonimadhuri commented Dec 3, 2022 •
edited by aduh95

Moving test-http-server-request-timeouts-mixed from tests/parallel to tests/sequential

The flaky test is reproducible when we run tools/test.py -j96 --repeat=1024 test/parallel/test-http-server-request-timeouts-mixed.js. I tried tuning the timeouts at which the values are asserted, but they still seem to fail because of timing issues when the system is burdened.

As a workaround, I have moved the test to run sequentially(verified it with tools/test.py -j96 --repeat=128 test/sequential/test-http-server-request-timeouts-mixed.js)

Fixes: #43465

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 3, 2022
@Trott Trott added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Dec 3, 2022
@Trott
Copy link
Member

Trott commented Dec 3, 2022

Closes: #43465

@Trott
Copy link
Member

Trott commented Dec 3, 2022

@nodejs/http @nodejs/testing

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48288/

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53418/

ShogunPanda
ShogunPanda approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks!

mcollina
mcollina approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This was referenced Aug 21, 2023
Open
Open
Open
@aduh95 aduh95 force-pushed the move_test_to_run_sequentially branch from 6ae29c5 to 07fcb59 Compare May 11, 2024 11:01
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59096/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 11, 2024
@aduh95 aduh95 merged commit b41ab9d into nodejs:main May 11, 2024
53 checks passed
@aduh95
Copy link
Contributor

aduh95 commented May 11, 2024

Landed in b41ab9d

targos pushed a commit that referenced this pull request May 12, 2024
@sonimadhuri @targos
test: move test-http-server-request-timeouts-mixed to sequential
5d91cf1 
PR-URL: #45722
Fixes: #43465
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@targos targos mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate flaky test-http-server-request-timeouts-mixed
7 participants
@sonimadhuri @Trott @nodejs-github-bot @aduh95 @mcollina @ShogunPanda @joyeecheung