Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix incorrect version history order #45728

Merged
merged 1 commit into from Dec 14, 2022

Commits on Dec 12, 2022

  1. tools: fix incorrect version history order

    This fixes an error in parseYAML(text), the version sorting
    coudn't be right as we compared an arrify string
    (ie. a = ["v18.11, v16.7.0"]) with an array of strings
    (ie. b = ["v18.07", "v16.7.0"]) in versionSort(a, b).
    
    minVersion(a) couldn't find the minimum version with an arrify string
    like a = ["v18.11, v16.7.0"].
    That's why incorrect version history orders sometimes appeared.
    
    Furthermore, no need to sort the added version as it always comes first.
    So, it can be the last one to be pushed in the meta.changes array.
    
    Fixes: nodejs#45670
    
    Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
    welfoz and lpinca committed Dec 12, 2022
    Copy the full SHA
    7f7ecaf View commit details
    Browse the repository at this point in the history