Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update eslint to 8.29.0 #45733

Merged
merged 1 commit into from Dec 14, 2022
Merged

tools: update eslint to 8.29.0 #45733

merged 1 commit into from Dec 14, 2022

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of eslint to 8.29.0.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 4, 2022
Trott
Trott approved these changes Dec 4, 2022
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@Trott Trott added request-ci Add this label to start a Jenkins CI on a PR. fast-track PRs that do not need to wait for 48 hours to land. labels Dec 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2022

Fast-track has been requested by @Trott. Please 👍 to approve.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 4, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 5, 2022
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/48298/

This was referenced Dec 7, 2022
Open
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/48455/

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 14, 2022
@nodejs-github-bot nodejs-github-bot merged commit cf0a42c into main Dec 14, 2022
@nodejs-github-bot
Copy link
Collaborator Author

Landed in cf0a42c

@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-eslint branch December 14, 2022 00:47
targos pushed a commit that referenced this pull request Jan 1, 2023
@nodejs-github-bot @targos
tools: update eslint to 8.29.0
27cf389 
PR-URL: #45733
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@nodejs-github-bot @juanarbol
tools: update eslint to 8.29.0
7438ff1 
PR-URL: #45733
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@tniessen tniessen tniessen approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nodejs-github-bot @Trott @lpinca @anonrig @tniessen @VoltrexKeyva