test_runner: refactor tap_lexer to use more primordials
#45744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dont-land-on-v14.x
needs-ci
MoLow
approved these changes
Dec 5, 2022
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
cjihrig
approved these changes
Dec 5, 2022
aduh95
commented
Dec 6, 2022
aduh95
added
request-ci
10 tasks
github-actions
bot
removed
the
request-ci
8 tasks
This was referenced Dec 9, 2022
11 tasks
11 tasks
aduh95
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/45744 ✔ Done loading data for nodejs/node/pull/45744 ----------------------------------- PR info ------------------------------------ Title test_runner: refactor `tap_lexer` to use more primordials (#45744) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:tap_lexer-primordials -> nodejs:main Labels author ready, needs-ci, dont-land-on-v14.x, commit-queue-squash, test_runner Commits 3 - test_runner: refactor `tap_lexer` to use more primordials - fixup! test_runner: refactor `tap_lexer` to use more primordials - Update lib/internal/test_runner/tap_lexer.js Committers 2 - Antoine du Hamel - GitHub PR-URL: https://github.com/nodejs/node/pull/45744 Reviewed-By: Moshe Atlow Reviewed-By: Colin Ihrig ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45744 Reviewed-By: Moshe Atlow Reviewed-By: Colin Ihrig -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - Update lib/internal/test_runner/tap_lexer.js ℹ This PR was created on Mon, 05 Dec 2022 11:18:28 GMT ✔ Approvals: 2 ✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/45744#pullrequestreview-1204376128 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/45744#pullrequestreview-1204637115 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-12-11T22:30:29Z: https://ci.nodejs.org/job/node-test-pull-request/48415/ - Querying data for job/node-test-pull-request/48415/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3671541884 |
|
Landed in 2483da7 |
ErickWendel
pushed a commit
to ErickWendel/node
that referenced
this pull request
Dec 12, 2022
PR-URL: nodejs#45744 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Dec 12, 2022
PR-URL: #45744 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
13 tasks
targos
pushed a commit
that referenced
this pull request
Dec 13, 2022
PR-URL: #45744 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
12 tasks
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45744 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 30, 2022
PR-URL: #45744 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 3, 2023
PR-URL: #45744 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 4, 2023
PR-URL: #45744 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 5, 2023
PR-URL: #45744 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MoLow
pushed a commit
to MoLow/node-core-test
that referenced
this pull request
Feb 2, 2023
PR-URL: nodejs/node#45744 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> (cherry picked from commit 2483da743cbb48f31c6b3f8cb186d89f31d73611)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.