deps: V8: cherry-pick bc831f8ba33b #45788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original commit message:
[fastcall] Implement support for onebyte string arguments
This CL adds one byte string specialization support for fast API call arguments.
It introduces a kOneByteString variant to CTypeInfo.
We see a ~6x improvement in Deno's TextEncoder#encode microbenchmark.
Rendered results: https://divy-v8-patches.deno.dev/
Bug: chromium:1052746
Change-Id: I47c3a9e101cd18ddc6ad58f627db3a34231b60f7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4036884
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Commit-Queue: Maya Lekova <mslekova@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84552}
Refs: v8/v8@bc831f8
|
Review requested:
|
nodejs-github-bot
added
build
addaleax
approved these changes
Dec 8, 2022
anonrig
added
author ready
github-actions
bot
removed
the
request-ci
gengjiawen
approved these changes
Dec 9, 2022
anonrig
added
the
commit-queue
daeyeon
approved these changes
Dec 9, 2022
gengjiawen
added
the
fast-track
|
Fast-track has been requested by @gengjiawen. Please 👍 to approve. |
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/45788 ✔ Done loading data for nodejs/node/pull/45788 ----------------------------------- PR info ------------------------------------ Title deps: V8: cherry-pick bc831f8ba33b (#45788) Author Yagiz Nizipli (@anonrig) Branch anonrig:v8/fast-api-string -> nodejs:main Labels build, v8 engine, fast-track, author ready, needs-ci Commits 1 - deps: V8: cherry-pick bc831f8ba33b Committers 1 - Yagiz Nizipli PR-URL: https://github.com/nodejs/node/pull/45788 Refs: https://github.com/v8/v8/commit/bc831f8ba33b79e2eb670faf1f84c4e39aeb0f9f Reviewed-By: Anna Henningsen Reviewed-By: Jiawen Geng Reviewed-By: Daeyeon Jeong ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45788 Refs: https://github.com/v8/v8/commit/bc831f8ba33b79e2eb670faf1f84c4e39aeb0f9f Reviewed-By: Anna Henningsen Reviewed-By: Jiawen Geng Reviewed-By: Daeyeon Jeong -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 08 Dec 2022 15:13:09 GMT ✔ Approvals: 3 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/45788#pullrequestreview-1210642814 ✔ - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/45788#pullrequestreview-1211011886 ✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/45788#pullrequestreview-1211148529 ℹ This PR is being fast-tracked ✖ Last GitHub CI failed ℹ Last Full PR CI on 2022-12-08T23:08:17Z: https://ci.nodejs.org/job/node-test-pull-request/48360/ - Querying data for job/node-test-pull-request/48360/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3656535524 |
nodejs-github-bot
added
the
commit-queue-failed
aymen94
approved these changes
Dec 9, 2022
9 tasks
gengjiawen
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 894aff7 |
This was referenced Dec 11, 2022
ErickWendel
pushed a commit
to ErickWendel/node
that referenced
this pull request
Dec 12, 2022
Original commit message:
[fastcall] Implement support for onebyte string arguments
This CL adds one byte string specialization support for fast API call arguments.
It introduces a kOneByteString variant to CTypeInfo.
We see a ~6x improvement in Deno's TextEncoder#encode microbenchmark.
Rendered results: https://divy-v8-patches.deno.dev/
Bug: chromium:1052746
Change-Id: I47c3a9e101cd18ddc6ad58f627db3a34231b60f7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4036884
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Commit-Queue: Maya Lekova <mslekova@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84552}
Refs: v8/v8@bc831f8
PR-URL: nodejs#45788
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
This was referenced Dec 13, 2022
targos
pushed a commit
that referenced
this pull request
Jan 1, 2023
Original commit message:
[fastcall] Implement support for onebyte string arguments
This CL adds one byte string specialization support for fast API call arguments.
It introduces a kOneByteString variant to CTypeInfo.
We see a ~6x improvement in Deno's TextEncoder#encode microbenchmark.
Rendered results: https://divy-v8-patches.deno.dev/
Bug: chromium:1052746
Change-Id: I47c3a9e101cd18ddc6ad58f627db3a34231b60f7
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4036884
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Commit-Queue: Maya Lekova <mslekova@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84552}
Refs: v8/v8@bc831f8
PR-URL: #45788
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Merged
|
This needs manual backport to v18.x |
juanarbol
added
the
backport-requested-v18.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referencing #45701, this commit from v8 can leverage different use cases (for example wasm), and I believe it shouldn't be blocked with my
encodeIntoexperiment.Original commit message:
Refs: v8/v8@bc831f8