Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: buffer.fill empty value #45794

Merged
merged 2 commits into from Dec 12, 2022
Merged

doc: buffer.fill empty value #45794

merged 2 commits into from Dec 12, 2022

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Dec 9, 2022 •
edited

Resolves: #45727
The doc is missing the case where the Buffer.fill value is empty.
I've created a test (not sure if necessary) and added the behaviour to the doc

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Dec 9, 2022
@marco-ippolito marco-ippolito changed the title doc: Buffer.fill empty value doc: buffer.fill empty value Dec 9, 2022
mscdex
mscdex reviewed Dec 9, 2022
View reviewed changes
doc/api/buffer.md Outdated Show resolved Hide resolved
@marco-ippolito @mscdex
doc: missing period
ca25dd3 
Co-authored-by: mscdex <mscdex@users.noreply.github.com>
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 10, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48379/

ShogunPanda
ShogunPanda approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

And no, there are never enough tests.

@ShogunPanda ShogunPanda added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Dec 12, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 12, 2022
@nodejs-github-bot nodejs-github-bot merged commit c6c3eea into nodejs:main Dec 12, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in c6c3eea

ErickWendel pushed a commit to ErickWendel/node that referenced this pull request Dec 12, 2022
@marco-ippolito @ErickWendel
doc: buffer.fill empty value
ec49bb1 
PR-URL: nodejs#45794
Fixes: nodejs#45727
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
targos pushed a commit that referenced this pull request Dec 12, 2022
@marco-ippolito @targos
doc: buffer.fill empty value
bb16e9f 
PR-URL: #45794
Fixes: #45727
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@targos targos mentioned this pull request Dec 12, 2022
Merged
targos pushed a commit that referenced this pull request Dec 13, 2022
@marco-ippolito @targos
doc: buffer.fill empty value
8a90f5c 
PR-URL: #45794
Fixes: #45727
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@marco-ippolito @danielleadams
doc: buffer.fill empty value
9fd831b 
PR-URL: #45794
Fixes: #45727
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@marco-ippolito @danielleadams
doc: buffer.fill empty value
a1b25c0 
PR-URL: #45794
Fixes: #45727
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@marco-ippolito @danielleadams
doc: buffer.fill empty value
108220c 
PR-URL: #45794
Fixes: #45727
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@marco-ippolito @danielleadams
doc: buffer.fill empty value
a17b6de 
PR-URL: #45794
Fixes: #45727
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@marco-ippolito @danielleadams
doc: buffer.fill empty value
d0513f2 
PR-URL: #45794
Fixes: #45727
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mscdex mscdex mscdex left review comments

@ShogunPanda ShogunPanda ShogunPanda approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The behavior of Buffer’s methods with an empty fill has not been documented.
5 participants
@marco-ippolito @nodejs-github-bot @mscdex @ShogunPanda @anonrig