Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: simplify NodeBIO::GetMethod initialization #45799

Merged
merged 1 commit into from Dec 11, 2022
Merged

src: simplify NodeBIO::GetMethod initialization #45799

merged 1 commit into from Dec 11, 2022
+5 −11

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Dec 9, 2022

Make its initialization self-contained to avoid unnecessarily breaking encapsulation.

@addaleax
src: simplify NodeBIO::GetMethod initialization
8fe8bf1 
Make its initialization self-contained to avoid unnecessarily
breaking encapsulation.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 9, 2022
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Dec 9, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 9, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48366/

anonrig
anonrig approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48368/

@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 9, 2022
@github-actions github-actions bot mentioned this pull request Dec 10, 2022
Open
9 tasks
@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 10, 2022
@github-actions github-actions bot mentioned this pull request Dec 11, 2022
Open
11 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 11, 2022
@nodejs-github-bot nodejs-github-bot merged commit d498bd9 into nodejs:main Dec 11, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in d498bd9

@github-actions github-actions bot mentioned this pull request Dec 12, 2022
Open
11 tasks
ErickWendel pushed a commit to ErickWendel/node that referenced this pull request Dec 12, 2022
@addaleax @ErickWendel
src: simplify NodeBIO::GetMethod initialization
7cf3620 
Make its initialization self-contained to avoid unnecessarily
breaking encapsulation.

PR-URL: nodejs#45799
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Dec 12, 2022
@addaleax @targos
src: simplify NodeBIO::GetMethod initialization
37db26f 
Make its initialization self-contained to avoid unnecessarily
breaking encapsulation.

PR-URL: #45799
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targos targos mentioned this pull request Dec 12, 2022
Merged
@github-actions github-actions bot mentioned this pull request Dec 13, 2022
Open
13 tasks
targos pushed a commit that referenced this pull request Dec 13, 2022
@addaleax @targos
src: simplify NodeBIO::GetMethod initialization
8a03684 
Make its initialization self-contained to avoid unnecessarily
breaking encapsulation.

PR-URL: #45799
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@github-actions github-actions bot mentioned this pull request Dec 14, 2022
Open
12 tasks
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@addaleax @danielleadams
src: simplify NodeBIO::GetMethod initialization
efab442 
Make its initialization self-contained to avoid unnecessarily
breaking encapsulation.

PR-URL: #45799
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@addaleax @danielleadams
src: simplify NodeBIO::GetMethod initialization
f61886f 
Make its initialization self-contained to avoid unnecessarily
breaking encapsulation.

PR-URL: #45799
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@addaleax @danielleadams
src: simplify NodeBIO::GetMethod initialization
8e1138d 
Make its initialization self-contained to avoid unnecessarily
breaking encapsulation.

PR-URL: #45799
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
@addaleax @danielleadams
src: simplify NodeBIO::GetMethod initialization
6e20519 
Make its initialization self-contained to avoid unnecessarily
breaking encapsulation.

PR-URL: #45799
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit that referenced this pull request Jan 5, 2023
@addaleax @danielleadams
src: simplify NodeBIO::GetMethod initialization
fec71b8 
Make its initialization self-contained to avoid unnecessarily
breaking encapsulation.

PR-URL: #45799
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@tniessen tniessen tniessen approved these changes

@JungMinu JungMinu JungMinu approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@addaleax @nodejs-github-bot @anonrig @tniessen @JungMinu @VoltrexKeyva