doc: remove last example use of require('crypto').webcrypto #45819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
panva
added
doc
tniessen
reviewed
Dec 11, 2022
panva
added
dont-land-on-v16.x
dont-land-on-v18.x
tniessen
approved these changes
Dec 11, 2022
panva
added
the
author ready
lpinca
approved these changes
Dec 11, 2022
panva
added
the
commit-queue
aduh95
approved these changes
Dec 11, 2022
marsonya
approved these changes
Dec 12, 2022
benjamingr
approved these changes
Dec 12, 2022
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/45819
✔ Done loading data for nodejs/node/pull/45819
----------------------------------- PR info ------------------------------------
Title doc: remove last example use of require('crypto').webcrypto (#45819)
Author Filip Skokan (@panva)
Branch panva:doc-webcrypto -> nodejs:main
Labels crypto, doc, author ready, dont-land-on-v16.x, dont-land-on-v18.x
Commits 1
- doc: remove last example use of require('crypto').webcrypto
Committers 1
- Filip Skokan
PR-URL: https://github.com/nodejs/node/pull/45819
Reviewed-By: Tobias Nießen
Reviewed-By: Luigi Pinca
Reviewed-By: Antoine du Hamel
Reviewed-By: Akhil Marsonya
Reviewed-By: Benjamin Gruenbaum
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45819
Reviewed-By: Tobias Nießen
Reviewed-By: Luigi Pinca
Reviewed-By: Antoine du Hamel
Reviewed-By: Akhil Marsonya
Reviewed-By: Benjamin Gruenbaum
--------------------------------------------------------------------------------
ℹ This PR was created on Sun, 11 Dec 2022 18:04:11 GMT
✔ Approvals: 5
✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/45819#pullrequestreview-1212752258
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/45819#pullrequestreview-1212754688
✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/45819#pullrequestreview-1212773819
✔ - Akhil Marsonya (@marsonya): https://github.com/nodejs/node/pull/45819#pullrequestreview-1212970449
✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/45819#pullrequestreview-1213064587
✔ Last GitHub CI successful
✖ No Jenkins CI runs detected
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3688108832 |
nodejs-github-bot
added
the
commit-queue-failed
|
Landed in 0665fa4 |
panva
added a commit
that referenced
this pull request
Dec 13, 2022
PR-URL: #45819 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jan 1, 2023
PR-URL: #45819 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the doc changes from #45817 aren't getting bashed I'm pushing them separately.