Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: enable idlharness WebCryptoAPI WPTs #45822

Merged
merged 1 commit into from Dec 13, 2022
Merged

test: enable idlharness WebCryptoAPI WPTs #45822

merged 1 commit into from Dec 13, 2022

Conversation

panva
Copy link
Member

@panva panva commented Dec 11, 2022

Enables the idlharness.https.any.js tests from WebCryptoAPI WPT to run, adding 73 new PASS tests and 9 acknowledged failures that I'll be dealing with on an ongoing basis.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 11, 2022
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 11, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 11, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48414/

@github-actions github-actions bot mentioned this pull request Dec 12, 2022
Open
11 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48417/

@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. dont-land-on-v16.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels Dec 12, 2022
@github-actions github-actions bot mentioned this pull request Dec 13, 2022
Open
13 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 13, 2022
@nodejs-github-bot nodejs-github-bot merged commit da41669 into nodejs:main Dec 13, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in da41669

@panva panva deleted the webcrypto-enable-wpt-idlharness branch December 13, 2022 22:01
@github-actions github-actions bot mentioned this pull request Dec 14, 2022
Open
12 tasks
@panva panva removed dont-land-on-v16.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels Dec 14, 2022
This was referenced Dec 15, 2022
Open
Open
targos pushed a commit that referenced this pull request Jan 1, 2023
@panva @targos
test: enable idlharness WebCryptoAPI WPTs
fea122d 
PR-URL: #45822
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2023
Merged
@juanarbol juanarbol added the dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. label Jan 24, 2023
@juanarbol
Copy link
Member

This is breaking the jstests in v18.x

/Users/juan/GitHub/node/test/common/wpt.js:548                                                                                                                                                 
        throw new Error(                                                                                                                                                                       
        ^                                                                                                                                                                                      
                                                                                                                                                                                               
Error: Found 1 unexpected passes. Consider updating test/wpt/status/WebCryptoAPI.json for these files:                                                                                         
idlharness.https.any.js                                                                                                                                                                        
    at process.<anonymous> (/Users/juan/GitHub/node/test/common/wpt.js:548:15)                                                                                                                 
    at process.emit (node:events:525:35)                                                                                                                                                                                                                                                                                                                                                      
Node.js v18.13.1-pre                                                                                                                                                                           
Command: out/Release/node /Users/juan/GitHub/node/test/wpt/test-webcrypto.js                                                                                                                                                                                                                                                                                                                  
                                                                                                                                                                                               
[08:21|% 100|+ 3785|-   1]: Done                                                                                                                                                                                                                                                                                                                                                              
Failed tests:                                                                                                                                                                                  
out/Release/node /Users/juan/GitHub/node/test/wpt/test-webcrypto.js                                                                                                                            
make: *** [jstest] Error 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@daeyeon daeyeon daeyeon approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@panva @nodejs-github-bot @juanarbol @lpinca @cjihrig @daeyeon @aduh95