doc: add pipeline and finished to stream/promises doc #45832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dependencies
marco-ippolito
force-pushed
the
doc/stream-promises
branch
from
e5f6cfc
to
f67e107
Compare
marco-ippolito
changed the title
marco-ippolito
force-pushed
the
doc/stream-promises
branch
3 times, most recently
from
acb6aa0
to
0eee704
Compare
marco-ippolito
force-pushed
the
doc/stream-promises
branch
from
0eee704
to
9175ce3
Compare
aduh95
reviewed
Dec 13, 2022
|
I've moved the async examples under the new async documentation and created links |
ShogunPanda
approved these changes
Dec 14, 2022
aduh95
reviewed
Dec 14, 2022
aduh95
approved these changes
Dec 15, 2022
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
added
author ready
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/45832 ✔ Done loading data for nodejs/node/pull/45832 ----------------------------------- PR info ------------------------------------ Title doc: add pipeline and finished to stream/promises doc (#45832) Author Marco Ippolito (@marco-ippolito) Branch marco-ippolito:doc/stream-promises -> nodejs:main Labels author ready, needs-ci, dependencies, commit-queue-squash Commits 6 - doc: add stream/promises pipeline and finished to doc - doc: fixed correct return type - doc: improved documentation - doc: typo removed > - doc: top level await and typo - doc: fix setImmediate Committers 2 - Marco Ippolito - GitHub PR-URL: https://github.com/nodejs/node/pull/45832 Fixes: https://github.com/nodejs/node/issues/45821 Reviewed-By: Paolo Insogna Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45832 Fixes: https://github.com/nodejs/node/issues/45821 Reviewed-By: Paolo Insogna Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - doc: fix setImmediate ℹ This PR was created on Mon, 12 Dec 2022 18:51:35 GMT ✔ Approvals: 2 ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/45832#pullrequestreview-1217021378 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/45832#pullrequestreview-1218851209 ✔ Last GitHub CI successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3703786198 |
aduh95
reviewed
Dec 15, 2022
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
Not sure why GitHub didn't run CI on the lastest commit, closing and reopening to trigger CI. |
aduh95
approved these changes
Dec 15, 2022
aduh95
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/45832 ✔ Done loading data for nodejs/node/pull/45832 ----------------------------------- PR info ------------------------------------ Title doc: add pipeline and finished to stream/promises doc (#45832) Author Marco Ippolito (@marco-ippolito) Branch marco-ippolito:doc/stream-promises -> nodejs:main Labels author ready, needs-ci, dependencies, commit-queue-squash Commits 8 - doc: add stream/promises pipeline and finished to doc - doc: fixed correct return type - doc: improved documentation - doc: typo removed > - doc: top level await and typo - doc: fix setImmediate - fix: period instead of : - doc: newline Committers 2 - Marco Ippolito - GitHub PR-URL: https://github.com/nodejs/node/pull/45832 Fixes: https://github.com/nodejs/node/issues/45821 Reviewed-By: Paolo Insogna Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/45832 Fixes: https://github.com/nodejs/node/issues/45821 Reviewed-By: Paolo Insogna Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 12 Dec 2022 18:51:35 GMT ✔ Approvals: 2 ✔ - Paolo Insogna (@ShogunPanda): https://github.com/nodejs/node/pull/45832#pullrequestreview-1217021378 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/45832#pullrequestreview-1219295708 ✔ Last GitHub CI successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3705387087 |
aduh95
added
doc
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4166d40 |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added to the doc the signature of
pipelineandfinishedwhich was missing.@ronag I've also added the
endfield which was mentioned here #34805 (comment) but I'm not sure if that's all right.Fixes: #45821