Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib,src: update exit codes #45841

Merged
merged 8 commits into from
Feb 26, 2023
Merged

lib,src: update exit codes #45841

merged 8 commits into from
Feb 26, 2023

Commits on Feb 19, 2023

  1. lib,src: update exit codes as per todos 

    Refs: nodejs#44746
    @debadree25
    debadree25 committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    057da6e View commit details
    Browse the repository at this point in the history

  2. test: update tests accordingly

    @debadree25
    debadree25 committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    488cefb View commit details
    Browse the repository at this point in the history

  3. remove TODO comments

    @debadree25
    debadree25 committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    771b4fd View commit details
    Browse the repository at this point in the history

  4. src: update comment 

    Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
    @debadree25 @joyeecheung
    debadree25 and joyeecheung committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    7b22b42 View commit details
    Browse the repository at this point in the history

  5. src,test: update snapshot failure in node.cc and associated test

    @debadree25
    debadree25 committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    f4f6b6b View commit details
    Browse the repository at this point in the history

  6. src: fix cpp linting

    @debadree25
    debadree25 committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    aaa272e View commit details
    Browse the repository at this point in the history

  7. fixup! lint fix

    @debadree25
    debadree25 committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    0a1a5a3 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2023

  1. fixup! test-snapshot-basic

    @debadree25
    debadree25 committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    f758e22 View commit details
    Browse the repository at this point in the history