Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: fix CryptoKey WebIDL conformance #45855

Closed
wants to merge 1 commit into from
Closed

crypto: fix CryptoKey WebIDL conformance #45855

wants to merge 1 commit into from

Conversation

panva
Copy link
Member

@panva panva commented Dec 14, 2022

CryptoKey getters need to check this and be enumerable.

@panva panva added crypto Issues and PRs related to the crypto subsystem. webcrypto labels Dec 14, 2022
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Dec 14, 2022
@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 14, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 14, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panva panva added dont-land-on-v16.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. and removed dont-land-on-v16.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels Dec 14, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 14, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request Dec 15, 2022
Open
9 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48499/

@github-actions github-actions bot mentioned this pull request Dec 16, 2022
Open
7 tasks
@panva panva removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 16, 2022
@panva
Copy link
Member Author

panva commented Dec 16, 2022

Landed in 43b7189

panva added a commit that referenced this pull request Dec 16, 2022
@panva
crypto: fix CryptoKey WebIDL conformance
43b7189 
PR-URL: #45855
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@panva panva closed this Dec 16, 2022
@panva panva deleted the fix-cryptokey-idl branch December 16, 2022 13:13
@aduh95
Copy link
Contributor

aduh95 commented Dec 16, 2022

This landed despite the latest Jenkins CI being red (and this change does affect the node binary).

node/doc/contributing/collaborator-guide.md

Lines 207 to 211 in 6831e2f

Do not land any pull requests without the necessary passing CI runs.
A passing (green) GitHub Actions CI result is required. A passing (green or
yellow) [Jenkins CI](https://ci.nodejs.org/) is also required if the pull
request contains changes that will affect the `node` binary. This is because
GitHub Actions CI does not cover all the environments supported by Node.js.

This was referenced Dec 17, 2022
Open
Open
@github-actions github-actions bot mentioned this pull request Dec 19, 2022
Open
14 tasks
targos pushed a commit that referenced this pull request Jan 1, 2023
@panva @targos
crypto: fix CryptoKey WebIDL conformance
6eede72 
PR-URL: #45855
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2023
Merged
@panva panva added dont-land-on-v16.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels Jan 24, 2023
@panva panva mentioned this pull request Jan 24, 2023
Closed
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@panva @juanarbol
crypto: fix CryptoKey WebIDL conformance
1a8aa50 
PR-URL: #45855
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@tniessen tniessen tniessen approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. needs-ci PRs that need a full CI run. webcrypto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@panva @nodejs-github-bot @aduh95 @lpinca @tniessen