Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove release cleanup step #45858

Merged
merged 1 commit into from Dec 16, 2022
Merged

doc: remove release cleanup step #45858

merged 1 commit into from Dec 16, 2022

Conversation

targos
Copy link
Member

@targos targos commented Dec 14, 2022

  • The pull request is automatically closed.
  • The branch is automatically deleted.

@targos
doc: remove release cleanup step
9dce84c 
- The pull request is automatically closed.
- The branch is automatically deleted.
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 14, 2022
RafaelGSS
RafaelGSS approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aduh95
Copy link
Contributor

aduh95 commented Dec 14, 2022

  • The pull request is automatically closed.
  • The branch is automatically deleted.

Is that true even for security releases?

@RafaelGSS
Copy link
Member

  • The pull request is automatically closed.
  • The branch is automatically deleted.

Is that true even for security releases?

The Pull Request is automatically closed, but the branch isn't deleted. I'm enabling it right now:

image

So I think we are good.

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 16, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 16, 2022
@nodejs-github-bot nodejs-github-bot merged commit a47939c into main Dec 16, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in a47939c

@nodejs-github-bot nodejs-github-bot deleted the targos-patch-1 branch December 16, 2022 14:14
targos added a commit that referenced this pull request Jan 1, 2023
@targos
doc: remove release cleanup step
dfa58c1 
- The pull request is automatically closed.
- The branch is automatically deleted.

PR-URL: #45858
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@targos @juanarbol
doc: remove release cleanup step
726b285 
- The pull request is automatically closed.
- The branch is automatically deleted.

PR-URL: #45858
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
@richardlau richardlau mentioned this pull request Oct 17, 2023
Merged
nodejs-github-bot pushed a commit that referenced this pull request Oct 20, 2023
@richardlau
doc: fix release process table of contents
8f3146e 
The table of contents for the release process still references a
deleted section. Remove that reference, and renumber the following
table of contents entries so that they link through to the correct
sections.

PR-URL: #50216
Refs: #45858
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
targos pushed a commit that referenced this pull request Oct 23, 2023
@richardlau @targos
doc: fix release process table of contents
2473aa3 
The table of contents for the release process still references a
deleted section. Remove that reference, and renumber the following
table of contents entries so that they link through to the correct
sections.

PR-URL: #50216
Refs: #45858
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@richardlau @alexfernandez
doc: fix release process table of contents
a63bcba 
The table of contents for the release process still references a
deleted section. Remove that reference, and renumber the following
table of contents entries so that they link through to the correct
sections.

PR-URL: nodejs#50216
Refs: nodejs#45858
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
@richardlau @targos
doc: fix release process table of contents
a9ba29b 
The table of contents for the release process still references a
deleted section. Remove that reference, and renumber the following
table of contents entries so that they link through to the correct
sections.

PR-URL: #50216
Refs: #45858
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnb bnb bnb approved these changes

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@targos @nodejs-github-bot @aduh95 @RafaelGSS @bnb @lpinca @richardlau