Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test,crypto: update WebCryptoAPI WPT #45860

Closed
wants to merge 1 commit into from
Closed

test,crypto: update WebCryptoAPI WPT #45860

wants to merge 1 commit into from

Conversation

panva
Copy link
Member

@panva panva commented Dec 14, 2022 •
edited

Ran git node wpt WebCryptoAPI to pull in the latest WPTs for WebCryptoAPI, opened and linked #45859 for the failures.

@panva panva added crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests. webcrypto labels Dec 14, 2022
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Dec 14, 2022
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 14, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 14, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48481/

@panva
Copy link
Member Author

panva commented Dec 14, 2022

cc @nodejs/crypto

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 14, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
aduh95
aduh95 approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 15, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48498/

@panva panva removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 16, 2022
@panva
Copy link
Member Author

panva commented Dec 16, 2022

Landed in 10c1c05

panva added a commit that referenced this pull request Dec 16, 2022
@panva
test,crypto: update WebCryptoAPI WPT
10c1c05 
PR-URL: #45860
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@panva panva closed this Dec 16, 2022
@panva panva deleted the webcrypto-wpt-bump-2 branch December 16, 2022 13:12
@aduh95
Copy link
Contributor

aduh95 commented Dec 16, 2022

This landed despite the latest Jenkins CI being red (and this change does affect the node binary).

node/doc/contributing/collaborator-guide.md

Lines 207 to 211 in 6831e2f

Do not land any pull requests without the necessary passing CI runs.
A passing (green) GitHub Actions CI result is required. A passing (green or
yellow) [Jenkins CI](https://ci.nodejs.org/) is also required if the pull
request contains changes that will affect the `node` binary. This is because
GitHub Actions CI does not cover all the environments supported by Node.js.

@panva
Copy link
Member Author

panva commented Dec 16, 2022

this change does affect the node binary

It does not.

@aduh95
Copy link
Contributor

aduh95 commented Dec 16, 2022 •
edited

Changing test/ qualifies as affecting the node binary, I don't know if "affect" is the best choice of words, but changing the test does affect what are the expectations for the behavior of node and must not land without a passing Jenkins CI.

node/doc/contributing/collaborator-guide.md

Lines 216 to 230 in 6831e2f

Changes in the following folders (except comment-only changes) are guaranteed to
affect the `node` binary:
* `deps/`
* `lib/`
* `src/`
* `test/`
* `tools/code_cache/`
* `tools/gyp/`
* `tools/icu/`
* `tools/inspector-protocol/`
* `tools/msvs/`
* `tools/snapshot/`
* `tools/v8_gypfiles/`

This was referenced Dec 17, 2022
Open
Open
Open
targos pushed a commit that referenced this pull request Jan 1, 2023
@panva @targos
test,crypto: update WebCryptoAPI WPT
b5e1245 
PR-URL: #45860
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@panva @juanarbol
test,crypto: update WebCryptoAPI WPT
da78f9c 
PR-URL: #45860
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@tniessen tniessen tniessen approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. webcrypto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@panva @nodejs-github-bot @aduh95 @lpinca @tniessen