test_runner: run t.after() if test body throws #45870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug where t.after() was not called if the test body threw an exception.
nodejs-github-bot
added
dont-land-on-v14.x
needs-ci
github-actions
bot
removed
the
request-ci
MoLow
added
author ready
13 tasks
nodejs-github-bot
removed
the
commit-queue
|
Landed in 385d595 |
This was referenced Dec 18, 2022
targos
pushed a commit
that referenced
this pull request
Jan 1, 2023
This commit fixes a bug where t.after() was not called if the test body threw an exception. PR-URL: #45870 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jan 26, 2023
This commit fixes a bug where t.after() was not called if the test body threw an exception. PR-URL: nodejs#45870 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jan 26, 2023
This commit fixes a bug where t.after() was not called if the test body threw an exception. PR-URL: nodejs#45870 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
This commit fixes a bug where t.after() was not called if the test body threw an exception. PR-URL: #45870 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
MoLow
pushed a commit
to MoLow/node-core-test
that referenced
this pull request
Feb 2, 2023
This commit fixes a bug where t.after() was not called if the test body threw an exception. PR-URL: nodejs/node#45870 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> (cherry picked from commit 385d595a4f1d887f6d4221e6071571132498d57c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug where
t.after()was not called if the test body threw an exception.