benchmark: include webstreams benchmark #45876
Conversation
nodejs-github-bot
added
the
benchmark
benchmark/webstreams/creation.js
Outdated
| function main({ n, kind }) { | ||
| switch (kind) { | ||
| case 'ReadableStream': | ||
| new ReadableStream({}); |
There was a problem hiding this comment.
It's better to assign the value to a binding outside the loop and do something about it in the end, otherwise the optimizing compiler might be smart enough to perform a dead code elimination and make the benchmark pointless.
There was a problem hiding this comment.
A typical technique for micro-benchmarking JS would be to pre-fill an array before the measurement starts, and you assign the values into that array during the benchmark (but do not grow or shrink it), then do something about the array in the end, in general the optimizing compiler won't attempt to eliminate the initializations in that case.
There was a problem hiding this comment.
Do we have a way to find dead code elimination? I tried some time ago with some V8 flags but it didn't work.
I've updated the code, does it solve? The benchmark results are the same.
There was a problem hiding this comment.
Do we have a way to find dead code elimination? I tried some time ago with some V8 flags but it didn't work.
You can try --trace-turbo* flags with --turbo-filter to filter out specific functions you want to take a look at (and use v8/tools/turbolizer to help looking at the output). But I'd say to benchmark Node.js's JS code the best solution is to just avoid micro-benchmarks and test a comprehensive combination of operations with varied input ;) e.g. the pipe-to benchmarks are less likely to be influenced by that.
There was a problem hiding this comment.
Indeed. I've created the creation.js to compare with streams/creation.js. This also shows how much memory it consumes (potential memory leak at some point IMHO - if you use the same n as streams it will get OOM).
RafaelGSS
force-pushed
the
benchmark/add-webstream
branch
from
e880275
to
846b57b
Compare
RafaelGSS
force-pushed
the
benchmark/add-webstream
branch
from
846b57b
to
931c086
Compare
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
RafaelGSS
force-pushed
the
benchmark/add-webstream
branch
from
931c086
to
0432fd4
Compare
anonrig
added
author ready
github-actions
bot
removed
the
request-ci
RafaelGSS
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 70d269d |
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #45876 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #45876 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #45876 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #45876 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #45876 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
This PR includes some basic benchmarks for Readable and Writable web streams. @jasnell do you think we should measure something in particular?
It's on my radar to improve the performance of web streams, but I'm not sure how fair is to compare it with regular streams.