Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: distinguish env stopping flags #45907

Merged
merged 1 commit into from Jan 14, 2023
Merged

src: distinguish env stopping flags #45907

merged 1 commit into from Jan 14, 2023

Commits on Jan 5, 2023

  1. src: distinguish env stopping flags 

    `Environment::FreeEnvironment` creates a
`DisallowJavascriptExecutionScope`, so the flag
`Environment::can_call_into_js()` should also be set as `false`. As
`Environment::can_call_into_js_` is a simple boolean flag, it should not
be accessed off-threads.
    @legendecas
    legendecas committed Jan 5, 2023
    Copy the full SHA
    3d49eed View commit details
    Browse the repository at this point in the history