lib: add deserialization callbacks for worker threads #45919
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyeecheung
reviewed
Dec 22, 2022
| @@ -107,7 +107,6 @@ function prepareExecution(options) { | |||
| // (including preload modules). | |||
| initializeClusterIPC(); | |||
|
|
|||
| // TODO(joyeecheung): do this for worker threads as well. | |||
| require('internal/v8/startup_snapshot').runDeserializeCallbacks(); | |||
There was a problem hiding this comment.
The worker thread also runs this function, you can just move this outside the block then it gets run by both.
For now though this isn't really meaningful because there aren't any deserialize callback added for the workers.
There was a problem hiding this comment.
I see so closing the PR for now
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have attempted to call the
runDeserializeCallbacks()in reference to// TODO(joyeecheung): do this for worker threads as well.cc @joyeecheung
(I have a feeling there might be more work to this if yes any guidance would be appreciated)
Refs: #44869