Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "deps: disable avx512 for simutf on benchmark ci" #45948

Merged
merged 1 commit into from Dec 24, 2022
Merged

Revert "deps: disable avx512 for simutf on benchmark ci" #45948

merged 1 commit into from Dec 24, 2022

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Dec 22, 2022 •
edited

This is no longer needed. Benchmark CI is now running Ubuntu 18.04. Referencing nodejs/build#3122

CC @nodejs/build

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Dec 22, 2022
@anonrig
Copy link
Member Author

anonrig commented Dec 22, 2022

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1277/

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 22, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 22, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48702/

@github-actions github-actions bot mentioned this pull request Dec 23, 2022
Open
13 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48705/

@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 23, 2022
@github-actions github-actions bot mentioned this pull request Dec 24, 2022
Open
12 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 24, 2022
@nodejs-github-bot nodejs-github-bot merged commit 07fdbbd into nodejs:main Dec 24, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 07fdbbd

This was referenced Dec 25, 2022
Open
Open
Open
Open
Open
Open
Open
@github-actions github-actions bot mentioned this pull request Jan 1, 2023
Open
20 tasks
targos pushed a commit that referenced this pull request Jan 1, 2023
@anonrig @targos
Revert "deps: disable avx512 for simutf on benchmark ci"
fd7561e 
This reverts commit 09f33c9.

PR-URL: #45948
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actions github-actions bot mentioned this pull request Jan 2, 2023
Open
22 tasks
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2023
Merged
RafaelGSS pushed a commit that referenced this pull request Jan 4, 2023
@anonrig @RafaelGSS
Revert "deps: disable avx512 for simutf on benchmark ci"
b181726 
This reverts commit 09f33c9.

PR-URL: #45948
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 5, 2023
@anonrig @RafaelGSS
Revert "deps: disable avx512 for simutf on benchmark ci"
05fee67 
This reverts commit 09f33c9.

PR-URL: #45948
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
@anonrig @juanarbol
Revert "deps: disable avx512 for simutf on benchmark ci"
cb767a2 
This reverts commit 09f33c9.

PR-URL: #45948
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
@anonrig @juanarbol
Revert "deps: disable avx512 for simutf on benchmark ci"
4063cdc 
This reverts commit 09f33c9.

PR-URL: #45948
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@anonrig @nodejs-github-bot @lpinca @targos