doc: make EventEmitterAsyncResource's options as optional
#45985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
lpinca
approved these changes
Dec 27, 2022
|
Fast-track has been requested by @lpinca. Please 👍 to approve. |
aymen94
approved these changes
Dec 27, 2022
anonrig
approved these changes
Dec 27, 2022
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 0bd8b43 |
targos
pushed a commit
that referenced
this pull request
Jan 1, 2023
Refs: https://github.com/nodejs/node/blob/main/lib/events.js#L140 PR-URL: #45985 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 4, 2023
Refs: https://github.com/nodejs/node/blob/main/lib/events.js#L140 PR-URL: #45985 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 5, 2023
Refs: https://github.com/nodejs/node/blob/main/lib/events.js#L140 PR-URL: #45985 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
juanarbol
pushed a commit
that referenced
this pull request
Jan 26, 2023
Refs: https://github.com/nodejs/node/blob/main/lib/events.js#L140 PR-URL: #45985 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Merged
juanarbol
pushed a commit
that referenced
this pull request
Jan 31, 2023
Refs: https://github.com/nodejs/node/blob/main/lib/events.js#L140 PR-URL: #45985 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: https://github.com/nodejs/node/blob/main/lib/events.js#L140