Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix setter of event.cancelBubble #45986

Merged
merged 4 commits into from Jan 7, 2023
Merged

doc: fix setter of event.cancelBubble #45986

merged 4 commits into from Jan 7, 2023

Commits on Dec 27, 2022

  1. doc: fix setter of event.cancelBubble 

    Setter of `event.cancelBubble` needs 1 argument(value).
And event.cancelBubble() is working if value is true.
But it's not described properly.

Refs: https://dom.spec.whatwg.org/#interface-event
    @deokjinkim
    deokjinkim committed Dec 27, 2022
    Copy the full SHA
    9dd8e84 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @deokjinkim @aduh95
    deokjinkim and aduh95 committed Dec 28, 2022
    Copy the full SHA
    e320789 View commit details
    Browse the repository at this point in the history

  2. Add missed Type: to specify data type 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @deokjinkim @aduh95
    deokjinkim and aduh95 committed Dec 28, 2022
    Copy the full SHA
    8f78b2e View commit details
    Browse the repository at this point in the history

  3. Revert change of JSDoc 

    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @deokjinkim @aduh95
    deokjinkim and aduh95 committed Dec 28, 2022
    Copy the full SHA
    31f921e View commit details
    Browse the repository at this point in the history